From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E48D38289E for ; Mon, 29 Apr 2024 15:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714405986; cv=none; b=llk3wVuoLSm/6CyIHqFL0GEVBEWmvx+pZYz8lSsMyXvKz+l8fOGOdCt6hxwxJfZ8LttkOWXfGOMHjtyaqF5kE42isvDuUml26xXQuwlixrYIPqXzqullSrcA5KHKnADRK/fFDS38Y1OgqijtyAXV8gOGXUzUxQf8Pj4lOzfBAPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714405986; c=relaxed/simple; bh=+Gy9RwHGHJ0e5OL0NRMNvIMDKmFymnkkxx/hxNe5NF4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e90nvZ5zB+zvEXpS69vQ8hyZSHxQLidOv+0dxfk/VytmuoQGKl65odbzC4m30f/ms2WolSSuutu9RI8eWglQu3d3uvuDzEM0BkOfKe4UBl3yOXTNevdEp/GFWe79R8GrK+sFHWp7iIVVrYHH5H5Hn1bhau5KXm2slSZDT3WDaR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Emn2PVfn; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Emn2PVfn" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1e5715a9ebdso38512955ad.2 for ; Mon, 29 Apr 2024 08:53:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714405984; x=1715010784; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5eP7J5rmRXvh7SkF0EcLKfWbbg6AxsrY7JazBQWQacI=; b=Emn2PVfns7oQ4XMJIYQqzUWBqou6AgdnUACrmBS+XqDnaxepDVoVbWZ8KhD1MvfkKy M3m4qduT79bcDh6/QTn9REeUzp5eSMqbn4apWFfWfeSUVDx/P86qLyhD7dktPVcNEQAE ryOjsLieB8qHUwqyHPy+k+XD6aKnsL9lMn+Dk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714405984; x=1715010784; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5eP7J5rmRXvh7SkF0EcLKfWbbg6AxsrY7JazBQWQacI=; b=wH2Ot8QCUTr6b6/Q0KDGYIvzdK5DjZtCIYeuIrSp7bAJ5qUL/7Tfy1FVWOgXryU0IY 6fJgxdoq7uRAbtzuG4TxtuhGD6kBJvDJ9gCkmRBHzdoXht4WMvUqytDBhh2SLnUhcOXi ctDeXQnjyHuWQdRcc9FZOkrmhXs/niSwpU+c/qDfI6UduME87NVmfMAhY1a23FxUOG6f Ceuf0elTdymUF/GHNgvIoJs9TEcjLjec6Sr16HVSH1BLmGRicAZRVe+yunNLQ4INs8tr XSrTBR+yHD5Z9DKaDjbjUtMv7R5doTawew0BytujrRj63y1BHbPxicX8ndsnyP8fi7Jk FWAA== X-Forwarded-Encrypted: i=1; AJvYcCVdLDPqiTllraQE8OywBBWV+79icjHXjcxMnqs+8uZhc1ZePkIkeLMP4zWWvVCks05md6rWuszYgahUl49et86TjPdiPl7V060xMrCMEZK6 X-Gm-Message-State: AOJu0YyV1/bc812QWMlHVUWGXqpV1iYlyrXIZPSWOJpnYZvsBMtUglVC mwONDaEiE23IyHMwHTey0x5Wv1NYWuozJK32T1IDrTxqIrtUj0hyrP3ocBMkAQ== X-Google-Smtp-Source: AGHT+IHSqyOxeblKePjbJ2HI0zhUUlfn734QZma9y5m9jhA8eDudR1ftPfekBbvZQWW6+1i/in1j4Q== X-Received: by 2002:a17:902:c950:b0:1e2:65b3:de68 with SMTP id i16-20020a170902c95000b001e265b3de68mr12287764pla.19.1714405984267; Mon, 29 Apr 2024 08:53:04 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id j10-20020a17090276ca00b001dd69aca213sm20332520plt.270.2024.04.29.08.53.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 08:53:03 -0700 (PDT) Date: Mon, 29 Apr 2024 08:53:03 -0700 From: Kees Cook To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: Christian Brauner , Jakub Kicinski , Mark Brown , Shengyu Li , Shuah Khan , "David S . Miller" , =?iso-8859-1?Q?G=FCnther?= Noack , Will Drewry , kernel test robot , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan Subject: Re: [PATCH v2 6/9] selftests/harness: Constify fixture variants Message-ID: <202404290853.858A4626@keescook> References: <20240429130931.2394118-1-mic@digikod.net> <20240429130931.2394118-7-mic@digikod.net> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240429130931.2394118-7-mic@digikod.net> On Mon, Apr 29, 2024 at 03:09:28PM +0200, Mickaël Salaün wrote: > FIXTURE_VARIANT_ADD() types are passed as const pointers to > FIXTURE_TEARDOWN(). Make that explicit by constifying the variants > declarations. > > Cc: Kees Cook > Cc: Shuah Khan > Cc: Will Drewry > Signed-off-by: Mickaël Salaün Reviewed-by: Kees Cook -- Kees Cook