From: Abhinav Jain <jain.abhinav177@gmail.com>
To: horms@kernel.org
Cc: davem@davemloft.net, edumazet@google.com,
jain.abhinav177@gmail.com, javier.carrasco.cruz@gmail.com,
kuba@kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, shuah@kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH] selftests: net: Add on/off checks for network interface non fixed features
Date: Sun, 9 Jun 2024 13:28:32 +0000 [thread overview]
Message-ID: <20240609132832.51890-1-jain.abhinav177@gmail.com> (raw)
In-Reply-To: <20240607180127.GG27689@kernel.org>
On Fri, 7 Jun 2024 19:01:27 +0100, Simon Horman wrote:
> Hi Abhinav,
>
> I suspect this will now only report a failure if tail fails,
> but ignore ethtool failures.
Hi Simon,
I agree, I missed this part earlier. After taking other suggestion
into account, we don't need this tail and I have removed it.
> Shellcheck warns that the above reads words rather than lines,
> and recommends using read instead.
>
> I think that is ok, because the construction reduces lines to single words.
> But it does seem a bit awkward to call grep, awk and sed for this.
>
> I wonder if the following construction nicer:
>
> while read -r FEATURE VALUE FIXED; do
> [ "$FEAT" != "Features" ] || continue # Skip "Features" line
> [ "$FIXED" != "[fixed]" ] || continue # Skip fixed features
> feature="${FEATURE%:*}"
> ...
> done < "$TMP_ETHTOOL_FEATURES"
I have re-submitted a v2 of patch here keeping the above change:
https://lore.kernel.org/all/20240609132124.51683-1-jain.abhinav177@gmail.com/
Please review. Thank you.
prev parent reply other threads:[~2024-06-09 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 21:27 [PATCH] selftests: net: Add on/off checks for network interface non fixed features Abhinav Jain
2024-06-07 18:01 ` Simon Horman
2024-06-09 13:28 ` Abhinav Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240609132832.51890-1-jain.abhinav177@gmail.com \
--to=jain.abhinav177@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox