From: Andrew Morton <akpm@linux-foundation.org>
To: Peter Xu <peterx@redhat.com>
Cc: Audra Mitchell <audra@redhat.com>,
viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
aarcange@redhat.com, rppt@linux.vnet.ibm.com, shli@fb.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
shuah@kernel.org, linux-kselftest@vger.kernel.org,
raquini@redhat.com
Subject: Re: [PATCH v2 1/3] Fix userfaultfd_api to return EINVAL as expected
Date: Mon, 24 Jun 2024 15:57:34 -0700 [thread overview]
Message-ID: <20240624155734.c93d8297922575a5b25797e1@linux-foundation.org> (raw)
In-Reply-To: <Zng-rfCPvSaGvL7p@x1n>
On Sun, 23 Jun 2024 11:26:37 -0400 Peter Xu <peterx@redhat.com> wrote:
> > > Fixes: e06f1e1dd499 ("userfaultfd: wp: enabled write protection in userfaultfd API")
> >
> > A userspace-triggerable WARN is bad. I added cc:stable to this.
>
> Andrew,
>
> Note that this change may fix a WARN, but it may also start to break
> userspace which might be worse if it happens, IMHO. I forgot to mention
> that here, but only mentioned that in v1, and from that POV not copying
> stable seems the right thing.
>
> https://lore.kernel.org/all/ZjuIEH8TW2tWcqXQ@x1n/
>
> In summary: I think we can stick with Fixes on e06f1e1dd499, but we
> don't copy stable. The major reason we don't copy stable here is
> not only about complexity of such backport, but also that there can
> be apps trying to pass in unsupported bits (even if the kernel
> didn't support it) but keep using MISSING mode only, then we
> shouldn't fail them easily after a stable upgrade. Just smells
> dangerous to backport.
OK. And I'll move it into the 6.11-rc1 queue, for the next merge window.
prev parent reply other threads:[~2024-06-24 22:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 18:12 [PATCH v2 1/3] Fix userfaultfd_api to return EINVAL as expected Audra Mitchell
2024-06-21 18:12 ` [PATCH v2 2/3] Update uffd-stress to handle EINVAL for unset config features Audra Mitchell
2024-06-21 21:26 ` Peter Xu
2024-06-21 18:12 ` [PATCH v2 3/3] Turn off test_uffdio_wp if CONFIG_PTE_MARKER_UFFD_WP is not configured Audra Mitchell
2024-06-21 21:27 ` Peter Xu
2024-06-24 13:53 ` Audra Mitchell
2024-06-24 14:42 ` Peter Xu
2024-06-25 23:05 ` Andrew Morton
2024-06-25 23:55 ` Peter Xu
2024-06-26 12:49 ` Audra Mitchell
2024-06-21 21:25 ` [PATCH v2 1/3] Fix userfaultfd_api to return EINVAL as expected Peter Xu
2024-06-22 1:03 ` Andrew Morton
2024-06-23 15:26 ` Peter Xu
2024-06-24 22:57 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240624155734.c93d8297922575a5b25797e1@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=audra@redhat.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=peterx@redhat.com \
--cc=raquini@redhat.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=shli@fb.com \
--cc=shuah@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox