From: allison.henderson@oracle.com
To: netdev@vger.kernel.org
Cc: linux-kselftest@vger.kernel.org, rds-devel@oss.oracle.com,
linux-rdma@vger.kernel.org, oberpar@linux.ibm.com,
chuck.lever@oracle.com, vegard.nossum@oracle.com,
Allison Henderson <allison.henderson@oracle.com>
Subject: [PATCH net-next v1 2/3] net: rds: add option for GCOV profiling
Date: Tue, 25 Jun 2024 18:28:33 -0700 [thread overview]
Message-ID: <20240626012834.5678-3-allison.henderson@oracle.com> (raw)
In-Reply-To: <20240626012834.5678-1-allison.henderson@oracle.com>
From: Vegard Nossum <vegard.nossum@oracle.com>
To better our unit tests we need code coverage to be part of the kernel.
This patch borrows heavily from how CONFIG_GCOV_PROFILE_FTRACE is
implemented
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
---
net/rds/Kconfig | 9 +++++++++
net/rds/Makefile | 5 +++++
2 files changed, 14 insertions(+)
diff --git a/net/rds/Kconfig b/net/rds/Kconfig
index 75cd696963b2..f007730aa2bb 100644
--- a/net/rds/Kconfig
+++ b/net/rds/Kconfig
@@ -26,3 +26,12 @@ config RDS_DEBUG
bool "RDS debugging messages"
depends on RDS
default n
+
+config GCOV_PROFILE_RDS
+ bool "Enable GCOV profiling on RDS"
+ depends on GCOV_KERNEL
+ help
+ Enable GCOV profiling on RDS for checking which functions/lines
+ are executed.
+
+ If unsure, say N.
diff --git a/net/rds/Makefile b/net/rds/Makefile
index 8fdc118e2927..3af1ca1d965c 100644
--- a/net/rds/Makefile
+++ b/net/rds/Makefile
@@ -15,3 +15,8 @@ rds_tcp-y := tcp.o tcp_connect.o tcp_listen.o tcp_recv.o \
tcp_send.o tcp_stats.o
ccflags-$(CONFIG_RDS_DEBUG) := -DRDS_DEBUG
+
+# for GCOV coverage profiling
+ifdef CONFIG_GCOV_PROFILE_RDS
+GCOV_PROFILE := y
+endif
--
2.25.1
next prev parent reply other threads:[~2024-06-26 1:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 1:28 [PATCH net-next v1 0/3] selftests: rds selftest allison.henderson
2024-06-26 1:28 ` [PATCH net-next v1 1/3] .gitignore: add .gcda files allison.henderson
2024-06-26 1:28 ` allison.henderson [this message]
2024-06-27 23:28 ` [PATCH net-next v1 2/3] net: rds: add option for GCOV profiling Jakub Kicinski
2024-06-26 1:28 ` [PATCH net-next v1 3/3] selftests: rds: add testing infrastructure allison.henderson
2024-06-27 23:32 ` Jakub Kicinski
2024-07-12 20:16 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626012834.5678-3-allison.henderson@oracle.com \
--to=allison.henderson@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=rds-devel@oss.oracle.com \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).