Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Denis Arefev <arefev@swemel.ru>
To: kuba@kernel.org
Cc: arefev@swemel.ru, davem@davemloft.net, edumazet@google.com,
	eperezma@redhat.com, jasowang@redhat.com,
	linux-kselftest@vger.kernel.org, mst@redhat.com,
	netdev@vger.kernel.org, pabeni@redhat.com, shuah@kernel.org,
	virtualization@lists.linux.dev, willemdebruijn.kernel@gmail.com,
	xuanzhuo@linux.alibaba.com
Subject: [PATCH net] virtio: fix GSO with frames unaligned to size
Date: Thu, 25 Jul 2024 12:22:03 +0300	[thread overview]
Message-ID: <20240725092203.26366-1-arefev@swemel.ru> (raw)
In-Reply-To: <20240723223109.2196886-1-kuba@kernel.org>

I checked the patch on three reproducers and all three DEFINITELY broke the core.

There are two malfunctions.

1. No flag skb_shinfo(skb)->tx_flags |= SKBFL_SHARED_FRAG;
 If it is not set then __skb_linearize will not be executed in skb_checksum_help.
 sk_buff remains fragmented (non-linear) and this is the first warning.
 OR add skb_shinfo(skb)->tx_flags |= SKBFL_SHARED_FRAG.
 OR ask Eric Dumazet (cef401de7be8c). Is checking if (skb_has_shared_frag(skb)) so important?
 in the skb_checksum_help function, is it enough if (skb_is_nonlinear(skb)) ?

2. The skb_segment algorithm and related checks, this is where you need time to think ...

Best regards Denis.

  parent reply	other threads:[~2024-07-25  9:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-23 22:31 [PATCH net] virtio: fix GSO with frames unaligned to size Jakub Kicinski
2024-07-24  3:48 ` Willem de Bruijn
2024-07-24 14:41   ` Jakub Kicinski
2024-07-25  2:52     ` Willem de Bruijn
2024-07-25  9:22 ` Denis Arefev [this message]
2024-07-25 14:27   ` Willem de Bruijn
2024-07-25 21:02     ` Willem de Bruijn
2024-07-25 10:17 ` Denis Arefev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240725092203.26366-1-arefev@swemel.ru \
    --to=arefev@swemel.ru \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=virtualization@lists.linux.dev \
    --cc=willemdebruijn.kernel@gmail.com \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox