Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Yury Norov <yury.norov@gmail.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Shuah Khan <shuah@kernel.org>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	kees@kernel.org, David Gow <davidgow@google.com>,
	John Hubbard <jhubbard@nvidia.com>
Cc: kernel@collabora.com
Subject: [PATCH 2/3] bitmap: Rename module
Date: Fri, 26 Jul 2024 16:06:57 +0500	[thread overview]
Message-ID: <20240726110658.2281070-3-usama.anjum@collabora.com> (raw)
In-Reply-To: <20240726110658.2281070-1-usama.anjum@collabora.com>

Rename module to bitmap_kunit and rename the configuration option
compliant with kunit framework.

Cc: kees@kernel.org
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
 MAINTAINERS                           |  2 +-
 lib/Kconfig.debug                     | 15 ++++++++-------
 lib/Makefile                          |  2 +-
 lib/{test_bitmap.c => bitmap_kunit.c} |  0
 4 files changed, 10 insertions(+), 9 deletions(-)
 rename lib/{test_bitmap.c => bitmap_kunit.c} (100%)

diff --git a/MAINTAINERS b/MAINTAINERS
index 12b870712da4a..289b727344d64 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3814,13 +3814,13 @@ F:	include/linux/find.h
 F:	include/linux/nodemask.h
 F:	include/linux/nodemask_types.h
 F:	include/vdso/bits.h
+F:	lib/bitmap_kunit.c
 F:	lib/bitmap-str.c
 F:	lib/bitmap.c
 F:	lib/cpumask.c
 F:	lib/cpumask_kunit.c
 F:	lib/find_bit.c
 F:	lib/find_bit_benchmark.c
-F:	lib/test_bitmap.c
 F:	tools/include/linux/bitfield.h
 F:	tools/include/linux/bitmap.h
 F:	tools/include/linux/bits.h
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index a30c03a661726..6bb02990a73e7 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -2420,13 +2420,6 @@ config TEST_PRINTF
 config TEST_SCANF
 	tristate "Test scanf() family of functions at runtime"
 
-config TEST_BITMAP
-	tristate "Test bitmap_*() family of functions at runtime"
-	help
-	  Enable this option to test the bitmap functions at boot.
-
-	  If unsure, say N.
-
 config TEST_UUID
 	tristate "Test functions located in the uuid module at runtime"
 
@@ -2813,6 +2806,14 @@ config USERCOPY_KUNIT_TEST
 	  on the copy_to/from_user infrastructure, making sure basic
 	  user/kernel boundary testing is working.
 
+config BITMAP_KUNIT_TEST
+	tristate "KUnit Test for bitmap_*() family of functions"
+	depends on KUNIT
+	default KUNIT_ALL_TESTS
+	help
+	  This builds the "bitmap_kunit" module that runs tests for
+	  bitmaps int the kernel making sure that there isn't any bug.
+
 config TEST_UDELAY
 	tristate "udelay test driver"
 	help
diff --git a/lib/Makefile b/lib/Makefile
index 322bb127b4dc6..37e7359a7065e 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -84,7 +84,6 @@ obj-$(CONFIG_TEST_DYNAMIC_DEBUG) += test_dynamic_debug.o
 obj-$(CONFIG_TEST_PRINTF) += test_printf.o
 obj-$(CONFIG_TEST_SCANF) += test_scanf.o
 
-obj-$(CONFIG_TEST_BITMAP) += test_bitmap.o
 ifeq ($(CONFIG_CC_IS_CLANG)$(CONFIG_KASAN),yy)
 # FIXME: Clang breaks test_bitmap_const_eval when KASAN and GCOV are enabled
 GCOV_PROFILE_test_bitmap.o := n
@@ -388,6 +387,7 @@ CFLAGS_fortify_kunit.o += $(DISABLE_STRUCTLEAK_PLUGIN)
 obj-$(CONFIG_FORTIFY_KUNIT_TEST) += fortify_kunit.o
 obj-$(CONFIG_SIPHASH_KUNIT_TEST) += siphash_kunit.o
 obj-$(CONFIG_USERCOPY_KUNIT_TEST) += usercopy_kunit.o
+obj-$(CONFIG_BITMAP_KUNIT_TEST) += bitmap_kunit.o
 
 obj-$(CONFIG_GENERIC_LIB_DEVMEM_IS_ALLOWED) += devmem_is_allowed.o
 
diff --git a/lib/test_bitmap.c b/lib/bitmap_kunit.c
similarity index 100%
rename from lib/test_bitmap.c
rename to lib/bitmap_kunit.c
-- 
2.39.2


  parent reply	other threads:[~2024-07-26 11:07 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-26 11:06 [PATCH 0/3] bitmap: Convert test_bitmap to kunit test Muhammad Usama Anjum
2024-07-26 11:06 ` [PATCH 1/3] bitmap: convert test_bitmap to KUnit test Muhammad Usama Anjum
2024-07-26 11:06 ` Muhammad Usama Anjum [this message]
2024-07-26 18:45   ` [PATCH 2/3] bitmap: Rename module John Hubbard
2024-07-29  7:57     ` Muhammad Usama Anjum
2024-07-26 19:24   ` Shuah Khan
2024-07-29  8:02     ` Muhammad Usama Anjum
2024-07-27 17:35   ` Yury Norov
2024-07-29  8:07     ` Muhammad Usama Anjum
2024-07-29 14:09       ` Randy Dunlap
2024-07-30  7:51         ` Muhammad Usama Anjum
2024-07-30 13:53           ` Randy Dunlap
2024-07-30 10:10         ` David Gow
2024-07-30 15:55           ` Shuah Khan
2024-07-30 18:17             ` Shuah Khan
2024-07-30 18:44               ` John Hubbard
2024-07-30 17:49           ` Yury Norov
2024-07-26 11:06 ` [PATCH 3/3] selftests: lib: remove test_bitmap Muhammad Usama Anjum
2024-07-26 19:22   ` Shuah Khan
2024-07-26 19:26 ` [PATCH 0/3] bitmap: Convert test_bitmap to kunit test Shuah Khan
2024-07-27 18:10   ` Yury Norov
2024-07-29  8:15     ` Muhammad Usama Anjum
2024-07-30 15:39       ` Shuah Khan
2024-07-31  3:05         ` David Gow
2024-07-29  8:29   ` Muhammad Usama Anjum
2024-07-30 15:49     ` Shuah Khan
2024-07-31  3:06       ` David Gow
2024-07-31 16:26         ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240726110658.2281070-3-usama.anjum@collabora.com \
    --to=usama.anjum@collabora.com \
    --cc=akpm@linux-foundation.org \
    --cc=davidgow@google.com \
    --cc=jhubbard@nvidia.com \
    --cc=kees@kernel.org \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=shuah@kernel.org \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox