Re: [PATCH v5 1/2] selftests: net: Create veth pair for testing in networkless kernel

[Abhinav Jain <jain.abhinav177@gmail.com>]

On Thu, 8 Aug 2024 09:23:09 -0700, Jakub Kicinski wrote:
> A number of checks now return SKIP because veth doesn't support all
> ethtool APIs.
>
> In netdev selftests we try to make sure SKIP is only used when test
> cannot be performed because of limitations of the environment.
> For example some tool is not installed, kernel doesn't have a config.
> Something that the person running the test is able to fix by fixing
> how the test is run.
>
> Running this test on veth will always SKIP, nothing CI system can do.
> Please make the test use the keyword XFAIL instead of SKIP when
> functionality is not supported by the underlying driver.

Ack, understood. I will do that, one clarification though.
Currently, the tests are using either PASS or FAIL and no SKIP. Based on
the above suggestion, it seems that I have replace FAIL with XFAIL for all
the tests that fail due to functionality not being supported by the
underlying driver.

Please confirm if my understanding is correct and I will send a v6 of the
series in accordance with netdev patch submission guidelines.
---