From: Abhinav Jain <jain.abhinav177@gmail.com>
To: kuba@kernel.org
Cc: davem@davemloft.net, edumazet@google.com,
jain.abhinav177@gmail.com, javier.carrasco.cruz@gmail.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com, shuah@kernel.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH net v6 0/2] Enhance network interface feature testing
Date: Thu, 15 Aug 2024 16:34:42 +0530 [thread overview]
Message-ID: <20240815110442.1389625-1-jain.abhinav177@gmail.com> (raw)
In-Reply-To: <20240814175748.35889b6d@kernel.org>
On Wed, 14 Aug 2024 17:57:48 -0700, Jakub Kicinski wrote:
> On Wed, 14 Aug 2024 17:56:51 -0700 Jakub Kicinski wrote:
> > On Wed, 14 Aug 2024 19:15:15 +0000 Abhinav Jain wrote:
> > > Changes in v6:
> > > Use XFAIL for ethtool operations that are unsupported instead of SKIP.
> >
> > One more:
> >
> > tools/testing/selftests/net/netdevice.sh: echo "SKIP: $netdev: set IP address"
> >
> > I think the SKIP -> XFAIL conversion should be a separate patch (for
> > total of 3 patches in the series).
>
> P.S. and please change the subject to [PATCH net-next], it's a net-next
> change, not a net fix.
I have sent v7 now with net-next instead of net:
https://lore.kernel.org/all/20240815105924.1389290-1-jain.abhinav177@gmail.com
For set IP address part, I have added logic to XFAIL if veth pair was created
and to SKIP if that's not the case in third patch of the series as directed above.
Right now, there is no logic to set IP address in the script for normal interfaces
either and it is a TODO as well. I will focus on it next after this one is applied.
Thank you for all the help Jakub.
next prev parent reply other threads:[~2024-08-15 11:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 19:15 [PATCH net v6 0/2] Enhance network interface feature testing Abhinav Jain
2024-08-14 19:15 ` [PATCH net v6 1/2] selftests: net: Create veth pair for testing in networkless kernel Abhinav Jain
2024-08-14 19:15 ` [PATCH net v6 2/2] selftests: net: Add on/off checks for non-fixed features of interface Abhinav Jain
2024-08-15 0:56 ` [PATCH net v6 0/2] Enhance network interface feature testing Jakub Kicinski
2024-08-15 0:57 ` Jakub Kicinski
2024-08-15 11:04 ` Abhinav Jain [this message]
2024-08-15 15:50 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815110442.1389625-1-jain.abhinav177@gmail.com \
--to=jain.abhinav177@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox