Re: [PATCH net-next v2 0/3] selftests/net: packetdrill: netns and two imports

Matthieu Baerts
2024-09-12T11:23:03Z

Hi Willem,

On 12/09/2024 02:52, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@google.com>
>
> 1/3: run in nets, as discussed, and add missing CONFIGs
> 2/3: import tcp/zerocopy
> 3/3: import tcp/slow_start

Thank you for the v2. This new version looks good to me:

Acked-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

I didn't pay too much attention to the new tests, because they look
good, heavily tested I suppose, and I guess the goal is not to diverge
from the original ones for the moment. Still, please note that the CI
reported some timing issues with tcp_zerocopy_closed.pkt when using a
debug kernel config, e.g.

> tcp_zerocopy_closed.pkt:22: timing error: expected system call return at 0.100596 sec but happened at 0.109564 sec; tolerance 0.004000 sec

https://netdev.bots.linux.dev/contest.html?executor=vmksft-packetdrill-dbg&test=tcp-zerocopy-closed-pkt

Cheers,
Matt
--