From: Jason Gunthorpe <jgg@ziepe.ca>
To: Will Deacon <will@kernel.org>
Cc: Yi Liu <yi.l.liu@intel.com>,
joro@8bytes.org, kevin.tian@intel.com, baolu.lu@linux.intel.com,
alex.williamson@redhat.com, eric.auger@redhat.com,
nicolinc@nvidia.com, chao.p.peng@linux.intel.com,
iommu@lists.linux.dev, zhenzhong.duan@intel.com,
linux-kselftest@vger.kernel.org, vasant.hegde@amd.com
Subject: Re: [PATCH v2 5/6] iommu/arm-smmu-v3: Make smmuv3 set_dev_pasid() op support replace
Date: Tue, 15 Oct 2024 13:27:40 -0300 [thread overview]
Message-ID: <20241015162740.GP1825128@ziepe.ca> (raw)
In-Reply-To: <20241015084322.GA19079@willie-the-truck>
On Tue, Oct 15, 2024 at 09:43:24AM +0100, Will Deacon wrote:
> > @@ -2890,6 +2891,7 @@ int arm_smmu_set_pasid(struct arm_smmu_master *master,
> > * already attached, no need to set old_domain.
> > */
> > .ssid = pasid,
> > + .old_domain = old,
>
> nit: The existing comment says "no need to set old_domain" and now you're
> doing exactly that! Please can you update the commentary (probably just
> remove the comment entirely)?
+1
Jason
next prev parent reply other threads:[~2024-10-15 16:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 13:04 [PATCH v2 0/6] Make set_dev_pasid op supporting domain replacement Yi Liu
2024-09-12 13:04 ` [PATCH v2 1/6] iommu: Pass old domain to set_dev_pasid op Yi Liu
2024-09-26 19:04 ` Jason Gunthorpe
2024-09-30 7:11 ` Tian, Kevin
2024-09-12 13:04 ` [PATCH v2 2/6] iommu/vt-d: Move intel_drain_pasid_prq() into intel_pasid_tear_down_entry() Yi Liu
2024-09-12 13:22 ` Baolu Lu
2024-09-13 12:10 ` Yi Liu
2024-09-13 2:11 ` Baolu Lu
2024-09-13 12:11 ` Yi Liu
2024-09-30 7:15 ` Tian, Kevin
2024-09-12 13:04 ` [PATCH v2 3/6] iommu/vt-d: Make intel_iommu_set_dev_pasid() to handle domain replacement Yi Liu
2024-09-13 1:35 ` Baolu Lu
2024-09-13 2:17 ` Baolu Lu
2024-09-13 12:18 ` Yi Liu
2024-09-30 7:19 ` Tian, Kevin
2024-10-09 1:09 ` Baolu Lu
2024-10-11 5:01 ` Tian, Kevin
2024-09-13 12:17 ` Yi Liu
2024-09-13 1:42 ` Baolu Lu
2024-09-13 12:21 ` Yi Liu
2024-09-14 1:03 ` Baolu Lu
2024-09-14 3:03 ` Liu, Yi L
2024-09-12 13:04 ` [PATCH v2 4/6] iommu/vt-d: Add set_dev_pasid callback for nested domain Yi Liu
2024-09-13 1:52 ` Baolu Lu
2024-09-13 12:22 ` Yi Liu
2024-09-30 7:19 ` Tian, Kevin
2024-09-12 13:04 ` [PATCH v2 5/6] iommu/arm-smmu-v3: Make smmuv3 set_dev_pasid() op support replace Yi Liu
2024-09-30 7:20 ` Tian, Kevin
2024-10-15 8:43 ` Will Deacon
2024-10-15 10:03 ` Yi Liu
2024-10-15 16:27 ` Jason Gunthorpe [this message]
2024-09-12 13:04 ` [PATCH v2 6/6] iommu: Make set_dev_pasid op support domain replacement Yi Liu
2024-09-26 19:06 ` Jason Gunthorpe
2024-09-30 7:20 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015162740.GP1825128@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=vasant.hegde@amd.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).