From: Johannes Weiner <hannes@cmpxchg.org>
To: Pintu Kumar <quic_pintu@quicinc.com>
Cc: shuah@kernel.org, surenb@google.com, peterz@infradead.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
skhan@linuxfoundation.org, pintu.ping@gmail.com
Subject: Re: [PATCH] selftests/sched: add basic test for psi
Date: Tue, 22 Oct 2024 10:05:56 -0400 [thread overview]
Message-ID: <20241022140556.GB219474@cmpxchg.org> (raw)
In-Reply-To: <20241022122158.2136-1-quic_pintu@quicinc.com>
On Tue, Oct 22, 2024 at 05:51:58PM +0530, Pintu Kumar wrote:
> There is a psi module that exists under kernel/sched/psi.
> Add a basic test to test the psi.
I'm not sure this is a valuable use of test cycles. The mere existence
and basic format of the files is very unlikely to be buggy, and such a
bug wouldn't hide for very long either.
> @@ -18548,10 +18548,12 @@ F: include/uapi/linux/pps.h
> PRESSURE STALL INFORMATION (PSI)
> M: Johannes Weiner <hannes@cmpxchg.org>
> M: Suren Baghdasaryan <surenb@google.com>
> +M: Pintu Kumar <quic_pintu@quicinc.com>
$ git log --oneline --author='Pintu Kumar' kernel/sched/psi.c | wc -l
0
Really? ;)
> R: Peter Ziljstra <peterz@infradead.org>
> S: Maintained
> F: include/linux/psi*
> F: kernel/sched/psi.c
> +F: tools/testing/selftests/sched/psi_test.c
>
> PRINTK
> M: Petr Mladek <pmladek@suse.com>
next prev parent reply other threads:[~2024-10-22 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 12:21 [PATCH] selftests/sched: add basic test for psi Pintu Kumar
2024-10-22 14:05 ` Johannes Weiner [this message]
2024-10-22 18:23 ` Pintu Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022140556.GB219474@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pintu.ping@gmail.com \
--cc=quic_pintu@quicinc.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox