Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Stanislav Fomichev <sdf@fomichev.me>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, andrew+netdev@lunn.ch,
	shuah@kernel.org, almasrymina@google.com, sdf@fomichev.me,
	willemb@google.com, petrm@nvidia.com
Subject: [PATCH net-next v5 07/12] selftests: ncdevmem: Properly reset flow steering
Date: Wed, 23 Oct 2024 08:43:57 -0700	[thread overview]
Message-ID: <20241023154402.441510-8-sdf@fomichev.me> (raw)
In-Reply-To: <20241023154402.441510-1-sdf@fomichev.me>

ntuple off/on might be not enough to do it on all NICs.
Add a bunch of shell crap to explicitly remove the rules.

Reviewed-by: Mina Almasry <almasrymina@google.com>
Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
---
 tools/testing/selftests/net/ncdevmem.c | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/tools/testing/selftests/net/ncdevmem.c b/tools/testing/selftests/net/ncdevmem.c
index 8e4a0fe74bb1..697771c1f9fa 100644
--- a/tools/testing/selftests/net/ncdevmem.c
+++ b/tools/testing/selftests/net/ncdevmem.c
@@ -217,13 +217,18 @@ void validate_buffer(void *line, size_t size)
 
 static int reset_flow_steering(void)
 {
-	int ret = 0;
-
-	ret = run_command("sudo ethtool -K %s ntuple off >&2", ifname);
-	if (ret)
-		return ret;
-
-	return run_command("sudo ethtool -K %s ntuple on >&2", ifname);
+	/* Depending on the NIC, toggling ntuple off and on might not
+	 * be allowed. Additionally, attempting to delete existing filters
+	 * will fail if no filters are present. Therefore, do not enforce
+	 * the exit status.
+	 */
+
+	run_command("sudo ethtool -K %s ntuple off >&2", ifname);
+	run_command("sudo ethtool -K %s ntuple on >&2", ifname);
+	run_command(
+		"sudo ethtool -n %s | grep 'Filter:' | awk '{print $2}' | xargs -n1 ethtool -N %s delete >&2",
+		ifname, ifname);
+	return 0;
 }
 
 static int configure_headersplit(bool on)
-- 
2.47.0


  parent reply	other threads:[~2024-10-23 15:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 15:43 [PATCH net-next v5 00/12] selftests: ncdevmem: Add ncdevmem to ksft Stanislav Fomichev
2024-10-23 15:43 ` [PATCH net-next v5 01/12] selftests: ncdevmem: Redirect all non-payload output to stderr Stanislav Fomichev
2024-10-23 15:43 ` [PATCH net-next v5 02/12] selftests: ncdevmem: Separate out dmabuf provider Stanislav Fomichev
2024-10-23 15:43 ` [PATCH net-next v5 03/12] selftests: ncdevmem: Unify error handling Stanislav Fomichev
2024-10-30  0:01   ` Jakub Kicinski
2024-10-30  0:15     ` Stanislav Fomichev
2024-10-23 15:43 ` [PATCH net-next v5 04/12] selftests: ncdevmem: Make client_ip optional Stanislav Fomichev
2024-10-23 15:43 ` [PATCH net-next v5 05/12] selftests: ncdevmem: Remove default arguments Stanislav Fomichev
2024-10-23 15:43 ` [PATCH net-next v5 06/12] selftests: ncdevmem: Switch to AF_INET6 Stanislav Fomichev
2024-10-23 15:43 ` Stanislav Fomichev [this message]
2024-10-23 15:43 ` [PATCH net-next v5 08/12] selftests: ncdevmem: Use YNL to enable TCP header split Stanislav Fomichev
2024-10-23 15:43 ` [PATCH net-next v5 09/12] selftests: ncdevmem: Remove hard-coded queue numbers Stanislav Fomichev
2024-10-23 15:44 ` [PATCH net-next v5 10/12] selftests: ncdevmem: Run selftest when none of the -s or -c has been provided Stanislav Fomichev
2024-10-23 15:44 ` [PATCH net-next v5 11/12] selftests: ncdevmem: Move ncdevmem under drivers/net/hw Stanislav Fomichev
2024-10-23 15:44 ` [PATCH net-next v5 12/12] selftests: ncdevmem: Add automated test Stanislav Fomichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241023154402.441510-8-sdf@fomichev.me \
    --to=sdf@fomichev.me \
    --cc=almasrymina@google.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=shuah@kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox