Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Stanislav Fomichev <sdf@fomichev.me>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, andrew+netdev@lunn.ch,
	shuah@kernel.org, horms@kernel.org, almasrymina@google.com,
	sdf@fomichev.me, willemb@google.com, petrm@nvidia.com
Subject: [PATCH net-next v7 09/12] selftests: ncdevmem: Remove hard-coded queue numbers
Date: Mon,  4 Nov 2024 10:14:27 -0800	[thread overview]
Message-ID: <20241104181430.228682-10-sdf@fomichev.me> (raw)
In-Reply-To: <20241104181430.228682-1-sdf@fomichev.me>

Use single last queue of the device and probe it dynamically.

Reviewed-by: Mina Almasry <almasrymina@google.com>
Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
---
 tools/testing/selftests/net/ncdevmem.c | 40 ++++++++++++++++++++++++--
 1 file changed, 38 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/ncdevmem.c b/tools/testing/selftests/net/ncdevmem.c
index be89735d6408..044198ce02a7 100644
--- a/tools/testing/selftests/net/ncdevmem.c
+++ b/tools/testing/selftests/net/ncdevmem.c
@@ -75,8 +75,8 @@ static char *server_ip;
 static char *client_ip;
 static char *port;
 static size_t do_validation;
-static int start_queue = 8;
-static int num_queues = 8;
+static int start_queue = -1;
+static int num_queues = 1;
 static char *ifname;
 static unsigned int ifindex;
 static unsigned int dmabuf_id;
@@ -208,6 +208,33 @@ void validate_buffer(void *line, size_t size)
 	fprintf(stdout, "Validated buffer\n");
 }
 
+static int rxq_num(int ifindex)
+{
+	struct ethtool_channels_get_req *req;
+	struct ethtool_channels_get_rsp *rsp;
+	struct ynl_error yerr;
+	struct ynl_sock *ys;
+	int num = -1;
+
+	ys = ynl_sock_create(&ynl_ethtool_family, &yerr);
+	if (!ys) {
+		fprintf(stderr, "YNL: %s\n", yerr.msg);
+		return -1;
+	}
+
+	req = ethtool_channels_get_req_alloc();
+	ethtool_channels_get_req_set_header_dev_index(req, ifindex);
+	rsp = ethtool_channels_get(ys, req);
+	if (rsp)
+		num = rsp->rx_count + rsp->combined_count;
+	ethtool_channels_get_req_free(req);
+	ethtool_channels_get_rsp_free(rsp);
+
+	ynl_sock_destroy(ys);
+
+	return num;
+}
+
 #define run_command(cmd, ...)                                           \
 	({                                                              \
 		char command[256];                                      \
@@ -715,6 +742,15 @@ int main(int argc, char *argv[])
 
 	ifindex = if_nametoindex(ifname);
 
+	if (start_queue < 0) {
+		start_queue = rxq_num(ifindex) - 1;
+
+		if (start_queue < 0)
+			error(1, 0, "couldn't detect number of queues\n");
+
+		fprintf(stderr, "using queues %d..%d\n", start_queue, start_queue + num_queues);
+	}
+
 	for (; optind < argc; optind++)
 		fprintf(stderr, "extra arguments: %s\n", argv[optind]);
 
-- 
2.47.0


  parent reply	other threads:[~2024-11-04 18:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-04 18:14 [PATCH net-next v7 00/12] selftests: ncdevmem: Add ncdevmem to ksft Stanislav Fomichev
2024-11-04 18:14 ` [PATCH net-next v7 01/12] selftests: ncdevmem: Redirect all non-payload output to stderr Stanislav Fomichev
2024-11-04 23:35   ` Joe Damato
2024-11-04 18:14 ` [PATCH net-next v7 02/12] selftests: ncdevmem: Separate out dmabuf provider Stanislav Fomichev
2024-11-04 23:43   ` Joe Damato
2024-11-04 18:14 ` [PATCH net-next v7 03/12] selftests: ncdevmem: Unify error handling Stanislav Fomichev
2024-11-04 23:46   ` Joe Damato
2024-11-05  3:29     ` Stanislav Fomichev
2024-11-04 18:14 ` [PATCH net-next v7 04/12] selftests: ncdevmem: Make client_ip optional Stanislav Fomichev
2024-11-04 23:48   ` Joe Damato
2024-11-04 18:14 ` [PATCH net-next v7 05/12] selftests: ncdevmem: Remove default arguments Stanislav Fomichev
2024-11-04 23:50   ` Joe Damato
2024-11-04 18:14 ` [PATCH net-next v7 06/12] selftests: ncdevmem: Switch to AF_INET6 Stanislav Fomichev
2024-11-04 23:55   ` Joe Damato
2024-11-05  1:54   ` Jakub Kicinski
2024-11-05  3:33     ` Stanislav Fomichev
2024-11-05 17:46       ` Stanislav Fomichev
2024-11-04 18:14 ` [PATCH net-next v7 07/12] selftests: ncdevmem: Properly reset flow steering Stanislav Fomichev
2024-11-04 23:56   ` Joe Damato
2024-11-04 18:14 ` [PATCH net-next v7 08/12] selftests: ncdevmem: Use YNL to enable TCP header split Stanislav Fomichev
2024-11-05  0:00   ` Joe Damato
2024-11-04 18:14 ` Stanislav Fomichev [this message]
2024-11-05  0:01   ` [PATCH net-next v7 09/12] selftests: ncdevmem: Remove hard-coded queue numbers Joe Damato
2024-11-04 18:14 ` [PATCH net-next v7 10/12] selftests: ncdevmem: Run selftest when none of the -s or -c has been provided Stanislav Fomichev
2024-11-05  0:11   ` Joe Damato
2024-11-05  3:31     ` Stanislav Fomichev
2024-11-04 18:14 ` [PATCH net-next v7 11/12] selftests: ncdevmem: Move ncdevmem under drivers/net/hw Stanislav Fomichev
2024-11-04 18:14 ` [PATCH net-next v7 12/12] selftests: ncdevmem: Add automated test Stanislav Fomichev
2024-11-05  0:15   ` Joe Damato
2024-11-05  1:34     ` Jakub Kicinski
2024-11-05  3:34     ` Stanislav Fomichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241104181430.228682-10-sdf@fomichev.me \
    --to=sdf@fomichev.me \
    --cc=almasrymina@google.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=shuah@kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox