From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <stsp2@yandex.ru>
Cc: <almasrymina@google.com>, <asml.silence@gmail.com>,
<axboe@kernel.dk>, <brauner@kernel.org>, <cyphar@cyphar.com>,
<davem@davemloft.net>, <edumazet@google.com>,
<gouhao@uniontech.com>, <horms@kernel.org>, <kees@kernel.org>,
<krisman@suse.de>, <kuba@kernel.org>, <kuniyu@amazon.com>,
<linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
<mhal@rbox.co>, <netdev@vger.kernel.org>, <oleg@redhat.com>,
<pabeni@redhat.com>, <quic_abchauha@quicinc.com>,
<shuah@kernel.org>, <tandersen@netflix.com>,
<viro@zeniv.linux.org.uk>, <willemb@google.com>
Subject: Re: [PATCH net-next v3] af_unix: pass pidfd flags via SCM_PIDFD cmsg
Date: Mon, 18 Nov 2024 09:54:52 -0800 [thread overview]
Message-ID: <20241118175452.54045-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20241116101120.323174-1-stsp2@yandex.ru>
From: Stas Sergeev <stsp2@yandex.ru>
Date: Sat, 16 Nov 2024 13:11:20 +0300
> Currently SCM_PIDFD cmsg cannot be sent via unix socket
> (returns -EINVAL) and SO_PASSPIDFD doesn't support flags.
> The created pidfd always has flags set to 0.
>
> This patch implements SCM_PIDFD cmsg in AF_UNIX socket, which
> can be used to send flags to SO_PASSPIDFD-enabled recipient.
>
> Self-test is added for the propagation of PIDFD_NONBLOCK flag.
>
> This is mainly needed for the future extensions, like eg this one:
> https://lore.kernel.org/lkml/8288a08e-448b-43c2-82dc-59f87d0d9072@yandex.ru/T/#me1237e46deba8574b77834b7704e63559ffef9cb
> where it was suggested to try solving the supplementary groups
> problem with pidfd.
>
> Changes in v3: specify target tree in patch subject
It seems you missed other feedback, especially __scm_recv_common()
needs a small change.
net-next is closed during the merge window for v6.13-rc1, so please
post v4 after Dec 2nd.
https://lore.kernel.org/netdev/20241118071654.695bb1a2@kernel.org/
next prev parent reply other threads:[~2024-11-18 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 10:11 [PATCH net-next v3] af_unix: pass pidfd flags via SCM_PIDFD cmsg Stas Sergeev
2024-11-18 17:54 ` Kuniyuki Iwashima [this message]
2024-11-19 9:47 ` stsp
2024-11-21 12:57 ` Alexander Mikhalitsyn
2024-11-21 13:37 ` stsp
2024-11-22 11:38 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241118175452.54045-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=almasrymina@google.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gouhao@uniontech.com \
--cc=horms@kernel.org \
--cc=kees@kernel.org \
--cc=krisman@suse.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=pabeni@redhat.com \
--cc=quic_abchauha@quicinc.com \
--cc=shuah@kernel.org \
--cc=stsp2@yandex.ru \
--cc=tandersen@netflix.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox