From: Siddharth Menon <simeddon@gmail.com>
To: simeddon@gmail.com, shuah@kernel.org
Cc: skhan@linuxfoundation.org, pmladek@suse.com, mbenes@suse.cz,
linux-kselftest@vger.kernel.org
Subject: [PATCH v2 1/2] selftests: Introduce script to validate required configs
Date: Sat, 21 Dec 2024 01:05:35 +0530 [thread overview]
Message-ID: <20241220193536.13781-2-simeddon@gmail.com> (raw)
In-Reply-To: <20241220193536.13781-1-simeddon@gmail.com>
This patch adds a script to validate that the current kernel configuration
satisfies the requirements for selftests. The script compares the current
kernel configs against the required selftest configs.
A config mismatch exits with error value 1 while matching configs or missing
config files exit with value 0.In order to get debug output, set the
environment variable LOCALMODCONFIG_DEBUG=1.
The code for extracting the current kernel configs is adapted from
scripts/kconfig/streamline_config.pl.
Suggested-by: Petr Mladek <pmladek@suse.com>
Suggested-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Siddharth Menon <simeddon@gmail.com>
---
v1->v2: created this perl script instead of checking directly in lib.mk
tools/testing/selftests/mktest.pl | 138 ++++++++++++++++++++++++++++++
1 file changed, 138 insertions(+)
create mode 100755 tools/testing/selftests/mktest.pl
diff --git a/tools/testing/selftests/mktest.pl b/tools/testing/selftests/mktest.pl
new file mode 100755
index 000000000000..60462f323bde
--- /dev/null
+++ b/tools/testing/selftests/mktest.pl
@@ -0,0 +1,138 @@
+#!/usr/bin/env perl
+# SPDX-License-Identifier: GPL-2.0
+use warnings;
+use strict;
+use Getopt::Long;
+use File::Spec;
+
+# set the environment variable LOCALMODCONFIG_DEBUG to get
+# debug output.
+my $debugprint = 0;
+$debugprint = 1 if (defined($ENV{LOCALMODCONFIG_DEBUG}));
+
+sub dprint {
+ return if (!$debugprint);
+ print STDERR @_;
+}
+
+my $uname = `uname -r`;
+chomp $uname;
+
+my @searchconfigs = (
+ {
+ "file" => ".config",
+ "exec" => "cat",
+ },
+ {
+ "file" => "/proc/config.gz",
+ "exec" => "zcat",
+ },
+ {
+ "file" => "/boot/config-$uname",
+ "exec" => "cat",
+ },
+ {
+ "file" => "/boot/vmlinuz-$uname",
+ "exec" => "scripts/extract-ikconfig",
+ "test" => "scripts/extract-ikconfig",
+ },
+ {
+ "file" => "vmlinux",
+ "exec" => "scripts/extract-ikconfig",
+ "test" => "scripts/extract-ikconfig",
+ },
+ {
+ "file" => "/lib/modules/$uname/kernel/kernel/configs.ko",
+ "exec" => "scripts/extract-ikconfig",
+ "test" => "scripts/extract-ikconfig",
+ },
+ {
+ "file" => "/lib/modules/$uname/build/.config",
+ "exec" => "cat",
+ },
+ {
+ "file" => "kernel/configs.ko",
+ "exec" => "scripts/extract-ikconfig",
+ "test" => "scripts/extract-ikconfig",
+ },
+ {
+ "file" => "kernel/configs.o",
+ "exec" => "scripts/extract-ikconfig",
+ "test" => "scripts/extract-ikconfig",
+ },
+);
+
+sub read_config {
+ foreach my $conf (@searchconfigs) {
+ my $file = $conf->{"file"};
+
+ next if (! -f "$file");
+
+ if (defined($conf->{"test"})) {
+ `$conf->{"test"} $conf->{"file"} 2>/dev/null`;
+ next if ($?);
+ }
+
+ my $exec = $conf->{"exec"};
+
+ dprint "Kernel config: '$file'\n";
+
+ open(my $infile, '-|', "$exec $file") || die "Failed to run $exec $file";
+ my @x = <$infile>;
+ close $infile;
+ return @x;
+ }
+ dprint "Unable to find kernel config file, skipping check\n";
+ exit 0;
+}
+
+# Check if selftest path is provided
+die "Usage: $0 <selftest_path>\n" unless @ARGV == 1;
+
+my $file_path = $ARGV[0];
+
+my @config_file = read_config();
+
+my %kern_configs;
+my $valid = "A-Za-z_0-9";
+foreach my $line (@config_file) {
+ chomp $line;
+ next if $line =~ /^\s*$/ || $line =~ /^#/;
+
+ if ($line =~ /^(CONFIG_\w+)=(.+)$/) {
+ $kern_configs{$1} = $2;
+ }
+}
+
+my %test_configs;
+# Continue as normal if /config file does not exist
+open(my $fh, '<', $file_path) or exit 0;
+
+while (my $line = <$fh>) {
+ chomp $line;
+ next if $line =~ /^\s*$/ || $line =~ /^#/;
+
+ if ($line =~ /^(CONFIG_\w+)=(.+)$/) {
+ $test_configs{$1} = $2;
+ }
+}
+close $fh;
+
+# Check if all selftest configs match kernel config
+my $all_match = 1;
+my @missing_or_mismatched;
+
+foreach my $key (keys %test_configs) {
+ if (!exists $kern_configs{$key} || $kern_configs{$key} ne $test_configs{$key}) {
+ push @missing_or_mismatched, "Required: $key=$test_configs{$key}";
+ $all_match = 0;
+ }
+}
+
+
+if ($all_match) {
+ exit 0;
+} else {
+ dprint "$_\n" for @missing_or_mismatched;
+ exit 1;
+}
--
2.39.5
next prev parent reply other threads:[~2024-12-20 19:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 19:35 [PATCH v2 0/2] update kselftest framework to check for required configs Siddharth Menon
2024-12-20 19:35 ` Siddharth Menon [this message]
2025-01-07 13:44 ` [PATCH v2 1/2] selftests: Introduce script to validate " Petr Mladek
2024-12-20 19:35 ` [PATCH v2 2/2] selftests/lib.mk: Introduce check " Siddharth Menon
2025-01-07 13:53 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241220193536.13781-2-simeddon@gmail.com \
--to=simeddon@gmail.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox