Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Jonathan Corbet <corbet@lwn.net>,
	 Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	 Jason Wang <jasowang@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	 Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	 Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
	Shuah Khan <shuah@kernel.org>,
	 linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	 netdev@vger.kernel.org, kvm@vger.kernel.org,
	 virtualization@lists.linux-foundation.org,
	linux-kselftest@vger.kernel.org,
	 Yuri Benditovich <yuri.benditovich@daynix.com>,
	 Andrew Melnychenko <andrew@daynix.com>,
	 Stephen Hemminger <stephen@networkplumber.org>,
	gur.stavi@huawei.com,  devel@daynix.com,
	Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH v2 0/3] tun: Unify vnet implementation and fill full vnet header
Date: Thu, 09 Jan 2025 15:58:42 +0900	[thread overview]
Message-ID: <20250109-tun-v2-0-388d7d5a287a@daynix.com> (raw)

When I implemented virtio's hash-related features to tun/tap [1],
I found tun/tap does not fill the entire region reserved for the virtio
header, leaving some uninitialized hole in the middle of the buffer
after read()/recvmesg().

This series fills the uninitialized hole. More concretely, the
num_buffers field will be initialized with 1, and the other fields will
be inialized with 0. Setting the num_buffers field to 1 is mandated by
virtio 1.0 [2].

The change to virtio header is preceded by another change that refactors
tun and tap to unify their virtio-related code.

[1]: https://lore.kernel.org/r/20241008-rss-v5-0-f3cf68df005d@daynix.com
[2]: https://lore.kernel.org/r/20241227084256-mutt-send-email-mst@kernel.org/

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
Changes in v2:
- Fixed num_buffers endian.
- Link to v1: https://lore.kernel.org/r/20250108-tun-v1-0-67d784b34374@daynix.com

---
Akihiko Odaki (3):
      tun: Unify vnet implementation
      tun: Pad virtio header with zero
      tun: Set num_buffers for virtio 1.0

 MAINTAINERS            |   1 +
 drivers/net/Kconfig    |   5 ++
 drivers/net/Makefile   |   1 +
 drivers/net/tap.c      | 174 ++++++----------------------------------
 drivers/net/tun.c      | 214 +++++++++----------------------------------------
 drivers/net/tun_vnet.c | 191 +++++++++++++++++++++++++++++++++++++++++++
 drivers/net/tun_vnet.h |  24 ++++++
 7 files changed, 283 insertions(+), 327 deletions(-)
---
base-commit: a32e14f8aef69b42826cf0998b068a43d486a9e9
change-id: 20241230-tun-66e10a49b0c7

Best regards,
-- 
Akihiko Odaki <akihiko.odaki@daynix.com>


             reply	other threads:[~2025-01-09  6:58 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-09  6:58 Akihiko Odaki [this message]
2025-01-09  6:58 ` [PATCH v2 1/3] tun: Unify vnet implementation Akihiko Odaki
2025-01-09 14:06   ` Willem de Bruijn
2025-01-10  8:28     ` Akihiko Odaki
2025-01-10  3:24   ` Jason Wang
2025-01-09  6:58 ` [PATCH v2 2/3] tun: Pad virtio header with zero Akihiko Odaki
2025-01-09  7:31   ` Michael S. Tsirkin
2025-01-09  7:41     ` Akihiko Odaki
2025-01-09  7:43       ` Michael S. Tsirkin
2025-01-09  9:36         ` Akihiko Odaki
2025-01-09 10:37           ` Jan Kara
2025-01-09 12:46       ` Willem de Bruijn
2025-01-10  4:38         ` Akihiko Odaki
2025-01-10  8:33           ` Michael S. Tsirkin
2025-01-10 10:45             ` Akihiko Odaki
2025-01-10 11:32               ` Willem de Bruijn
2025-01-09  7:42     ` Michael S. Tsirkin
2025-01-10  3:27   ` Jason Wang
2025-01-10 10:25     ` Akihiko Odaki
2025-01-09  6:58 ` [PATCH v2 3/3] tun: Set num_buffers for virtio 1.0 Akihiko Odaki
2025-01-09  7:32   ` Michael S. Tsirkin
2025-01-09  7:40     ` Michael S. Tsirkin
2025-01-09  9:38       ` Akihiko Odaki
2025-01-09 10:54         ` Michael S. Tsirkin
2025-01-09 11:10           ` Akihiko Odaki
2025-01-10  3:27   ` Jason Wang
2025-01-10 10:04     ` Akihiko Odaki
2025-01-10 10:23     ` Michael S. Tsirkin
2025-01-10 11:12       ` Akihiko Odaki
2025-01-13  3:04         ` Jason Wang
2025-01-15  5:07           ` Akihiko Odaki
2025-01-16  1:06             ` Jason Wang
2025-01-16  5:30               ` Akihiko Odaki
2025-01-20  0:40                 ` Jason Wang
2025-01-20  4:57                   ` Akihiko Odaki
2025-01-09 13:46 ` [PATCH v2 0/3] tun: Unify vnet implementation and fill full vnet header Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250109-tun-v2-0-388d7d5a287a@daynix.com \
    --to=akihiko.odaki@daynix.com \
    --cc=andrew@daynix.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=devel@daynix.com \
    --cc=edumazet@google.com \
    --cc=gur.stavi@huawei.com \
    --cc=jasowang@redhat.com \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=willemdebruijn.kernel@gmail.com \
    --cc=xuanzhuo@linux.alibaba.com \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox