Re: [PATCH v4 2/3] selftests: Move PCI Endpoint tests from tools/pci to Kselftests

Manivannan Sadhasivam
2024-12-31T18:54:10Z

On Tue, Dec 31, 2024 at 06:17:05PM +0100, Niklas Cassel wrote:
> On Tue, Dec 31, 2024 at 06:43:40PM +0530, Manivannan Sadhasivam wrote:
> > This just moves the existing tests under tools/pci to
> > tools/testing/selftests/pci_endpoint and adjusts the paths in Makefile
> > accordingly. Migration to Kselftest framework will be done in subsequent
> > commits.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> Why not squash this patch with the subsequent patch that actually
> converts the tests to kselftests?
>
> If you just apply this patch, then we have moved the code to
> testing/selftests/ but the tests are not actually kselftests,
> which doesn't really make sense IMO.
>

As I mentioned in the cover letter, this was suggested by both Shuah and Bjorn
to preserve the history:

https://lore.kernel.org/linux-pci/b2a5db97-dc59-33ab-71cd-f591e0b1b34d@linuxfoundation.org/
https://lore.kernel.org/linux-pci/20230117195903.GA142672@bhelgaas/

- Mani

--
மணிவண்ணன் சதாசிவம்