From: "Günther Noack" <gnoack3000@gmail.com>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: "Günther Noack" <gnoack@google.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kselftest@vger.kernel.org,
"Nathan Chancellor" <nathan@kernel.org>,
"Tahera Fahimi" <fahimitahera@gmail.com>
Subject: Re: [PATCH v1] selftests/landlock: Fix build with non-default pthread linking
Date: Fri, 17 Jan 2025 13:39:23 +0100 [thread overview]
Message-ID: <20250117.434d5503a465@gnoack.org> (raw)
In-Reply-To: <20250115145409.312226-1-mic@digikod.net>
On Wed, Jan 15, 2025 at 03:54:07PM +0100, Mickaël Salaün wrote:
> Old toolchains require explicit -lpthread (e.g. on Debian 11).
>
> Cc: Günther Noack <gnoack@google.com>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Tahera Fahimi <fahimitahera@gmail.com>
> Fixes: c8994965013e ("selftests/landlock: Test signal scoping for threads")
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> ---
> tools/testing/selftests/landlock/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/landlock/Makefile b/tools/testing/selftests/landlock/Makefile
> index 348e2dbdb4e0..480f13e77fcc 100644
> --- a/tools/testing/selftests/landlock/Makefile
> +++ b/tools/testing/selftests/landlock/Makefile
> @@ -13,11 +13,11 @@ TEST_GEN_PROGS := $(src_test:.c=)
> TEST_GEN_PROGS_EXTENDED := true
>
> # Short targets:
> -$(TEST_GEN_PROGS): LDLIBS += -lcap
> +$(TEST_GEN_PROGS): LDLIBS += -lcap -lpthread
> $(TEST_GEN_PROGS_EXTENDED): LDFLAGS += -static
>
> include ../lib.mk
>
> # Targets with $(OUTPUT)/ prefix:
> -$(TEST_GEN_PROGS): LDLIBS += -lcap
> +$(TEST_GEN_PROGS): LDLIBS += -lcap -lpthread
> $(TEST_GEN_PROGS_EXTENDED): LDFLAGS += -static
> --
> 2.48.1
>
Reviewed-by: Günther Noack <gnoack3000@gmail.com>
prev parent reply other threads:[~2025-01-17 12:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 14:54 [PATCH v1] selftests/landlock: Fix build with non-default pthread linking Mickaël Salaün
2025-01-17 12:39 ` Günther Noack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250117.434d5503a465@gnoack.org \
--to=gnoack3000@gmail.com \
--cc=fahimitahera@gmail.com \
--cc=gnoack@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox