From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 556D922ACD1; Sun, 26 Jan 2025 15:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737903900; cv=none; b=I6aTY2q3Dsxwr6mloEX0PSMijlke576oPIU0Pj2TgjnUyEVZrSuHRMV+x69BxZ/leFETmZ+3lrwUL9L16uSkYzcJ91pYWf25ntOqkUofuq9ek+B1FS2mFLIjO/41AXNSmfYaSN753cbc7UA5KreH4AGyQut26HY/MgxJQclC2pA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737903900; c=relaxed/simple; bh=vawUk/qXa04AQnHkGUqDCnq5OBcbHO8vec18ktLQm9g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YyKKSYryH33/to3QBAUbln+C5WAKgMXgavyiXVR2G9BZ3MuXi+bhzk2Ug0VP4RUzqak3hpKZq27399LQmSJwWIvpiWY+SW2oYs7Jpoc7sGdb11nw2BC0Q3sahlq8CoyW99AncNqa/G5gCF6CyekRQKIi+Gt2bX8+6wLFcMa2o0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C5He/+5V; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C5He/+5V" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 816FCC4CEE2; Sun, 26 Jan 2025 15:04:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737903899; bh=vawUk/qXa04AQnHkGUqDCnq5OBcbHO8vec18ktLQm9g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C5He/+5V7rLNxrrSBxWJgWeBOGZoG7GQq9VIexHEMJ+I0oYdJ/YUL9BfJv6Px5tF4 3Qvou+DwbTDHv3DCMV8n5MRloMyLUIDWiOA3F47nuLKA4W7/rzInFtJ/USmICVUbow zwyE5fFzpb3P+u3E40wzSEWuYncGcr9gwOTceTKnl6AVYRUKLPu3Umlk+PjO/iDKD9 C2+LE9qL0Q+5BPxdNWq2UqhYjO49buv/NPh8SIa28B5u3hVy3PxCKUse5q3D/citE7 BEUj5jnOT8/In2K+Quxrn75E09VU8vBSZAk1mA0QQHGo0F23Wjikc+OaJBx08x9sEj rAwg2KwcdaGaA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Liu Ye , Jakub Kicinski , Sasha Levin , steffen.klassert@secunet.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, shuah@kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 14/14] selftests/net/ipsec: Fix Null pointer dereference in rtattr_pack() Date: Sun, 26 Jan 2025 10:04:30 -0500 Message-Id: <20250126150430.958708-14-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250126150430.958708-1-sashal@kernel.org> References: <20250126150430.958708-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.177 Content-Transfer-Encoding: 8bit From: Liu Ye [ Upstream commit 3a0b7fa095212b51ed63892540c4f249991a2d74 ] Address Null pointer dereference / undefined behavior in rtattr_pack (note that size is 0 in the bad case). Flagged by cppcheck as: tools/testing/selftests/net/ipsec.c:230:25: warning: Possible null pointer dereference: payload [nullPointer] memcpy(RTA_DATA(attr), payload, size); ^ tools/testing/selftests/net/ipsec.c:1618:54: note: Calling function 'rtattr_pack', 4th argument 'NULL' value is 0 if (rtattr_pack(&req.nh, sizeof(req), XFRMA_IF_ID, NULL, 0)) { ^ tools/testing/selftests/net/ipsec.c:230:25: note: Null pointer dereference memcpy(RTA_DATA(attr), payload, size); ^ Signed-off-by: Liu Ye Link: https://patch.msgid.link/20250116013037.29470-1-liuye@kylinos.cn Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- tools/testing/selftests/net/ipsec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/ipsec.c b/tools/testing/selftests/net/ipsec.c index c5be3f390849b..ae3da27b00973 100644 --- a/tools/testing/selftests/net/ipsec.c +++ b/tools/testing/selftests/net/ipsec.c @@ -189,7 +189,8 @@ static int rtattr_pack(struct nlmsghdr *nh, size_t req_sz, attr->rta_len = RTA_LENGTH(size); attr->rta_type = rta_type; - memcpy(RTA_DATA(attr), payload, size); + if (payload) + memcpy(RTA_DATA(attr), payload, size); return 0; } -- 2.39.5