From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Hari Bathini <hbathini@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 2/8] tracing: tprobe-events: Reject invalid tracepoint name
Date: Wed, 26 Feb 2025 10:10:52 -0500 [thread overview]
Message-ID: <20250226101052.2fa3ce66@gandalf.local.home> (raw)
In-Reply-To: <174055073461.4079315.15875502830565214255.stgit@mhiramat.tok.corp.google.com>
On Wed, 26 Feb 2025 15:18:54 +0900
"Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Commit 57a7e6de9e30 ("tracing/fprobe: Support raw tracepoints on
> future loaded modules") allows user to set a tprobe on non-exist
> tracepoint but it does not check the tracepoint name is acceptable.
> So it leads tprobe has a wrong character for events (e.g. with
> subsystem prefix). In this case, the event is not shown in the
> events directory.
>
> Reject such invalid tracepoint name.
>
> The tracepoint name must consist of alphabet or digit or '_'.
>
> Fixes: 57a7e6de9e30 ("tracing/fprobe: Support raw tracepoints on future loaded modules")
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> Cc: stable@vger.kernel.org
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
> ---
> kernel/trace/trace_fprobe.c | 13 +++++++++++++
> kernel/trace/trace_probe.h | 1 +
> 2 files changed, 14 insertions(+)
next prev parent reply other threads:[~2025-02-26 15:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 6:18 [PATCH 0/8] tracing: probes: Fixes and enhancing error logs Masami Hiramatsu (Google)
2025-02-26 6:18 ` [PATCH 1/8] tracing: tprobe-events: Fix a memory leak when tprobe with $retval Masami Hiramatsu (Google)
2025-02-26 15:09 ` Steven Rostedt
2025-02-26 6:18 ` [PATCH 2/8] tracing: tprobe-events: Reject invalid tracepoint name Masami Hiramatsu (Google)
2025-02-26 15:10 ` Steven Rostedt [this message]
2025-02-26 15:50 ` Markus Elfring
2025-02-26 6:19 ` [PATCH 3/8] tracing: fprobe-events: Log error for exceeding the number of entry args Masami Hiramatsu (Google)
2025-02-26 15:22 ` Steven Rostedt
2025-02-26 22:10 ` Masami Hiramatsu
2025-02-26 6:19 ` [PATCH 4/8] tracing: probe-events: Log errro for exceeding the number of arguments Masami Hiramatsu (Google)
2025-02-26 15:29 ` Steven Rostedt
2025-02-26 16:13 ` Markus Elfring
2025-02-27 0:19 ` Masami Hiramatsu
2025-02-27 10:13 ` [4/8] " Markus Elfring
2025-03-03 2:17 ` [PATCH 4/8] " Masami Hiramatsu
2025-02-26 6:19 ` [PATCH 5/8] tracing: probe-events: Remove unused MAX_ARG_BUF_LEN macro Masami Hiramatsu (Google)
2025-02-26 15:32 ` Steven Rostedt
2025-02-26 6:19 ` [PATCH 6/8] selftests/ftrace: Expand the tprobe event test to check wrong format Masami Hiramatsu (Google)
2025-02-26 6:19 ` [PATCH 7/8] selftests/ftrace: Add new syntax error test Masami Hiramatsu (Google)
2025-02-26 6:19 ` [PATCH 8/8] selftests/ftrace: Add dynamic events argument limitation test case Masami Hiramatsu (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226101052.2fa3ce66@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=hbathini@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox