linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Breno Leitao <leitao@debian.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,  Shuah Khan <shuah@kernel.org>,
	Simon Horman <horms@kernel.org>,
	 Jonathan Corbet <corbet@lwn.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
	 Manu Bretelle <chantr4@gmail.com>,
	kernel-team@meta.com
Subject: [PATCH net-next 3/6] netconsole: add 'sysdata' suffix to related functions
Date: Fri, 14 Mar 2025 10:58:47 -0700	[thread overview]
Message-ID: <20250314-netcons_release-v1-3-07979c4b86af@debian.org> (raw)
In-Reply-To: <20250314-netcons_release-v1-0-07979c4b86af@debian.org>

This commit appends a common "sysdata" suffix to functions responsible
for appending data to sysdata.

This change enhances code clarity and prevents naming conflicts with
other "append" functions, particularly in anticipation of the upcoming
inclusion of the `release` field in the next patch.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/netconsole.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index 0914d29b48d8e..970dfc3ac9d41 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -1224,7 +1224,7 @@ static void populate_configfs_item(struct netconsole_target *nt,
 	init_target_config_group(nt, target_name);
 }
 
-static int append_cpu_nr(struct netconsole_target *nt, int offset)
+static int sysdata_append_cpu_nr(struct netconsole_target *nt, int offset)
 {
 	/* Append cpu=%d at extradata_complete after userdata str */
 	return scnprintf(&nt->extradata_complete[offset],
@@ -1232,7 +1232,7 @@ static int append_cpu_nr(struct netconsole_target *nt, int offset)
 			 raw_smp_processor_id());
 }
 
-static int append_taskname(struct netconsole_target *nt, int offset)
+static int sysdata_append_taskname(struct netconsole_target *nt, int offset)
 {
 	return scnprintf(&nt->extradata_complete[offset],
 			 MAX_EXTRADATA_ENTRY_LEN, " taskname=%s\n",
@@ -1256,9 +1256,9 @@ static int prepare_extradata(struct netconsole_target *nt)
 		goto out;
 
 	if (nt->sysdata_fields & SYSDATA_CPU_NR)
-		extradata_len += append_cpu_nr(nt, extradata_len);
+		extradata_len += sysdata_append_cpu_nr(nt, extradata_len);
 	if (nt->sysdata_fields & SYSDATA_TASKNAME)
-		extradata_len += append_taskname(nt, extradata_len);
+		extradata_len += sysdata_append_taskname(nt, extradata_len);
 
 	WARN_ON_ONCE(extradata_len >
 		     MAX_EXTRADATA_ENTRY_LEN * MAX_EXTRADATA_ITEMS);

-- 
2.47.1


  parent reply	other threads:[~2025-03-14 17:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-14 17:58 [PATCH net-next 0/6] netconsole: Add support for userdata release Breno Leitao
2025-03-14 17:58 ` [PATCH net-next 1/6] netconsole: introduce 'release' as a new sysdata field Breno Leitao
2025-03-19 15:40   ` Simon Horman
2025-03-14 17:58 ` [PATCH net-next 2/6] netconsole: implement configfs for release_enabled Breno Leitao
2025-03-19 15:40   ` Simon Horman
2025-03-14 17:58 ` Breno Leitao [this message]
2025-03-19 15:41   ` [PATCH net-next 3/6] netconsole: add 'sysdata' suffix to related functions Simon Horman
2025-03-14 17:58 ` [PATCH net-next 4/6] netconsole: append release to sysdata Breno Leitao
2025-03-19 15:41   ` Simon Horman
2025-03-14 17:58 ` [PATCH net-next 5/6] selftests: netconsole: Add tests for 'release' feature in sysdata Breno Leitao
2025-03-19 15:41   ` Simon Horman
2025-03-14 17:58 ` [PATCH net-next 6/6] docs: netconsole: document release feature Breno Leitao
2025-03-19 15:42   ` Simon Horman
2025-03-21 18:10 ` [PATCH net-next 0/6] netconsole: Add support for userdata release patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250314-netcons_release-v1-3-07979c4b86af@debian.org \
    --to=leitao@debian.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=chantr4@gmail.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).