From: Frank Li <Frank.Li@nxp.com>
To: "Kishon Vijay Abraham I" <kishon@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Anup Patel" <apatel@ventanamicro.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Marc Zyngier" <maz@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Arnd Bergmann" <arnd@arndb.de>, "Shuah Khan" <shuah@kernel.org>,
"Richard Zhu" <hongxing.zhu@nxp.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: Niklas Cassel <cassel@kernel.org>,
dlemoal@kernel.org, jdmason@kudzu.us,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
linux-kselftest@vger.kernel.org, imx@lists.linux.dev,
devicetree@vger.kernel.org, Frank Li <Frank.Li@nxp.com>
Subject: [PATCH v16 01/15] platform-msi: Add msi_remove_device_irq_domain() in platform_device_msi_free_irqs_all()
Date: Fri, 04 Apr 2025 15:01:02 -0400 [thread overview]
Message-ID: <20250404-ep-msi-v16-1-d4919d68c0d0@nxp.com> (raw)
In-Reply-To: <20250404-ep-msi-v16-0-d4919d68c0d0@nxp.com>
platform_device_msi_init_and_alloc_irqs() performs two tasks: allocating
the MSI domain for a platform device, and allocate a number of MSIs in that
domain.
platform_device_msi_free_irqs_all() only frees the MSIs, and leaves the MSI
domain alive.
Given that platform_device_msi_init_and_alloc_irqs() is the sole tool a
platform device has to allocate platform MSIs, it would make sense for
platform_device_msi_free_irqs_all() to teardown the MSI domain at the same
time as the MSIs.
This also avoids warnings and unexpected behaviours when a driver
repeatedly allocates and frees MSIs.
Acked-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v14 to v16
- use Marc Zyngier's suggested commit message
- Add Marc Zyngier's ack tag
change from v14 to v15
- none
change from v13 to v14
- bring back from v9 and remove fixup and cc stable before it is new use
case.
---
drivers/base/platform-msi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c
index 0e60dd650b5e0..70db08f3ac6fa 100644
--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -95,5 +95,6 @@ EXPORT_SYMBOL_GPL(platform_device_msi_init_and_alloc_irqs);
void platform_device_msi_free_irqs_all(struct device *dev)
{
msi_domain_free_irqs_all(dev, MSI_DEFAULT_DOMAIN);
+ msi_remove_device_irq_domain(dev, MSI_DEFAULT_DOMAIN);
}
EXPORT_SYMBOL_GPL(platform_device_msi_free_irqs_all);
--
2.34.1
next prev parent reply other threads:[~2025-04-04 19:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 19:01 [PATCH v16 00/15] PCI: EP: Add RC-to-EP doorbell with platform MSI controller Frank Li
2025-04-04 19:01 ` Frank Li [this message]
2025-04-04 19:01 ` [PATCH v16 02/15] irqdomain: Add IRQ_DOMAIN_FLAG_MSI_IMMUTABLE and irq_domain_is_msi_immutable() Frank Li
2025-04-04 19:01 ` [PATCH v16 03/15] irqchip/gic-v3-its: Set IRQ_DOMAIN_FLAG_MSI_IMMUTABLE for ITS Frank Li
2025-04-04 19:01 ` [PATCH v16 04/15] dt-bindings: pci: pci-msi: Add support for PCI Endpoint msi-map Frank Li
2025-04-04 20:11 ` Rob Herring
2025-04-04 20:33 ` Frank Li
2025-04-04 21:52 ` Rob Herring
2025-04-04 19:01 ` [PATCH v16 05/15] irqchip/gic-v3-its: Add support for device tree msi-map and msi-mask Frank Li
2025-04-04 19:01 ` [PATCH v16 06/15] PCI: endpoint: Set ID and of_node for function driver Frank Li
2025-04-04 19:01 ` [PATCH v16 07/15] PCI: endpoint: Add RC-to-EP doorbell support using platform MSI controller Frank Li
2025-04-04 19:01 ` [PATCH v16 08/15] PCI: endpoint: pci-ep-msi: Add MSI address/data pair mutable check Frank Li
2025-04-04 19:01 ` [PATCH v16 09/15] PCI: endpoint: Add pci_epf_align_inbound_addr() helper for address alignment Frank Li
2025-04-04 19:01 ` [PATCH v16 10/15] PCI: endpoint: pci-epf-test: Add doorbell test support Frank Li
2025-04-04 19:01 ` [PATCH v16 11/15] misc: pci_endpoint_test: Add doorbell test case Frank Li
2025-04-04 19:01 ` [PATCH v16 12/15] selftests: pci_endpoint: " Frank Li
2025-04-04 19:01 ` [PATCH v16 13/15] pci: imx6: Add helper function imx_pcie_add_lut_by_rid() Frank Li
2025-04-04 19:01 ` [PATCH v16 14/15] pci: imx6: Add LUT setting for MSI/IOMMU in Endpoint mode Frank Li
2025-04-04 19:01 ` [PATCH v16 15/15] arm64: dts: imx95: Add msi-map for pci-ep device Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250404-ep-msi-v16-1-d4919d68c0d0@nxp.com \
--to=frank.li@nxp.com \
--cc=apatel@ventanamicro.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=jdmason@kudzu.us \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=maz@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).