[PATCH RESEND] kunit: qemu_configs: SH: Respect kunit cmdline

[PATCH RESEND] kunit: qemu_configs: SH: Respect kunit cmdline

[Thomas Weißschuh]

The default SH kunit configuration sets CONFIG_CMDLINE_OVERWRITE which
completely disregards the cmdline passed from the bootloader/QEMU in favor
of the builtin CONFIG_CMDLINE.
However the kunit tool needs to pass arguments to the in-kernel kunit core,
for filters and other runtime parameters.

Enable CONFIG_CMDLINE_EXTEND instead, so kunit arguments are respected.

Fixes: 8110a3cab05e ("kunit: tool: Add support for SH under QEMU")
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
 tools/testing/kunit/qemu_configs/sh.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/testing/kunit/qemu_configs/sh.py b/tools/testing/kunit/qemu_configs/sh.py
index 78a474a5b95f3a7d6064a2d3b728810ced095606..f00cb89fdef6aa1c0abd83ca18e7004a4fdd96e1 100644
--- a/tools/testing/kunit/qemu_configs/sh.py
+++ b/tools/testing/kunit/qemu_configs/sh.py
@@ -7,7 +7,9 @@ CONFIG_CPU_SUBTYPE_SH7751R=y
 CONFIG_MEMORY_START=0x0c000000
 CONFIG_SH_RTS7751R2D=y
 CONFIG_RTS7751R2D_PLUS=y
-CONFIG_SERIAL_SH_SCI=y''',
+CONFIG_SERIAL_SH_SCI=y
+CONFIG_CMDLINE_EXTEND=y
+''',
 			   qemu_arch='sh4',
 			   kernel_path='arch/sh/boot/zImage',
 			   kernel_command_line='console=ttySC1',

---
base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
change-id: 20250220-kunit-sh-f42a3a8cce35

Best regards,
-- 
Thomas Weißschuh <thomas.weissschuh@linutronix.de>

Re: [PATCH RESEND] kunit: qemu_configs: SH: Respect kunit cmdline

[David Gow]

[-- Attachment #1: Type: text/plain, Size: 833 bytes --]

On Mon, 7 Apr 2025 at 16:58, Thomas Weißschuh
<thomas.weissschuh@linutronix.de> wrote:
>
> The default SH kunit configuration sets CONFIG_CMDLINE_OVERWRITE which
> completely disregards the cmdline passed from the bootloader/QEMU in favor
> of the builtin CONFIG_CMDLINE.
> However the kunit tool needs to pass arguments to the in-kernel kunit core,
> for filters and other runtime parameters.
>
> Enable CONFIG_CMDLINE_EXTEND instead, so kunit arguments are respected.
>
> Fixes: 8110a3cab05e ("kunit: tool: Add support for SH under QEMU")
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---

Huh, that's odd.

Anyway, this makes sense as a fix: even if sh eventually decides to do
the sane thing and make this default.

Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5281 bytes --]