linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
To: "Shuah Khan" <shuah@kernel.org>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Willy Tarreau" <w@1wt.eu>,
	"Thomas Weißschuh" <linux@weissschuh.net>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Subject: [PATCH v2 04/32] selftests: harness: Mark functions without prototypes static
Date: Mon, 07 Apr 2025 08:52:27 +0200	[thread overview]
Message-ID: <20250407-nolibc-kselftest-harness-v2-4-f8812f76e930@linutronix.de> (raw)
In-Reply-To: <20250407-nolibc-kselftest-harness-v2-0-f8812f76e930@linutronix.de>

With -Wmissing-prototypes the compiler will warn about non-static
functions which don't have a prototype defined.
As they are not used from a different compilation unit they don't need to
be defined globally.

Avoid the issue by marking the functions static.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
 tools/testing/selftests/kselftest_harness.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
index 2b350ed60b2bf1cbede8e3a9b4ac5fe716900144..5822bc0b86a3c623fd34830fb8b541b27672a00b 100644
--- a/tools/testing/selftests/kselftest_harness.h
+++ b/tools/testing/selftests/kselftest_harness.h
@@ -258,7 +258,7 @@
  * A bare "return;" statement may be used to return early.
  */
 #define FIXTURE_SETUP(fixture_name) \
-	void fixture_name##_setup( \
+	static void fixture_name##_setup( \
 		struct __test_metadata __attribute__((unused)) *_metadata, \
 		FIXTURE_DATA(fixture_name) __attribute__((unused)) *self, \
 		const FIXTURE_VARIANT(fixture_name) \
@@ -307,7 +307,7 @@
 	__FIXTURE_TEARDOWN(fixture_name)
 
 #define __FIXTURE_TEARDOWN(fixture_name) \
-	void fixture_name##_teardown( \
+	static void fixture_name##_teardown( \
 		struct __test_metadata __attribute__((unused)) *_metadata, \
 		FIXTURE_DATA(fixture_name) __attribute__((unused)) *self, \
 		const FIXTURE_VARIANT(fixture_name) \
@@ -987,7 +987,7 @@ static void __timeout_handler(int sig, siginfo_t *info, void *ucontext)
 	kill(-(t->pid), SIGKILL);
 }
 
-void __wait_for_test(struct __test_metadata *t)
+static void __wait_for_test(struct __test_metadata *t)
 {
 	struct sigaction action = {
 		.sa_sigaction = __timeout_handler,
@@ -1205,9 +1205,9 @@ static bool test_enabled(int argc, char **argv,
 	return !has_positive;
 }
 
-void __run_test(struct __fixture_metadata *f,
-		struct __fixture_variant_metadata *variant,
-		struct __test_metadata *t)
+static void __run_test(struct __fixture_metadata *f,
+		       struct __fixture_variant_metadata *variant,
+		       struct __test_metadata *t)
 {
 	struct __test_xfail *xfail;
 	char test_name[1024];

-- 
2.49.0


  parent reply	other threads:[~2025-04-07  6:53 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07  6:52 [PATCH v2 00/32] kselftest harness and nolibc compatibility Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 01/32] selftests: harness: Add harness selftest Thomas Weißschuh
2025-04-10 15:19   ` Shuah Khan
2025-04-07  6:52 ` [PATCH v2 02/32] selftests: harness: Use C89 comment style Thomas Weißschuh
2025-04-10 15:33   ` Shuah Khan
2025-04-07  6:52 ` [PATCH v2 03/32] selftests: harness: Ignore unused variant argument warning Thomas Weißschuh
2025-04-10 15:33   ` Shuah Khan
2025-04-07  6:52 ` Thomas Weißschuh [this message]
2025-04-07  6:52 ` [PATCH v2 05/32] selftests: harness: Remove inline qualifier for wrappers Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 06/32] selftests: harness: Remove dependency on libatomic Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 07/32] selftests: harness: Implement test timeouts through pidfd Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 08/32] selftests: harness: Don't set setup_completed for fixtureless tests Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 09/32] selftests: harness: Always provide "self" and "variant" Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 10/32] selftests: harness: Move teardown conditional into test metadata Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 11/32] selftests: harness: Add teardown callback to " Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 12/32] selftests: harness: Stop using setjmp()/longjmp() Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 13/32] selftests: harness: Guard includes on nolibc Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 14/32] tools/nolibc: handle intmax_t/uintmax_t in printf Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 15/32] tools/nolibc: use intmax definitions from compiler Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 16/32] tools/nolibc: use pselect6_time64 if available Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 17/32] tools/nolibc: use ppoll_time64 " Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 18/32] tools/nolibc: add tolower() and toupper() Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 19/32] tools/nolibc: add _exit() Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 20/32] tools/nolibc: add setpgrp() Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 21/32] tools/nolibc: implement waitpid() in terms of waitid() Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 22/32] Revert "selftests/nolibc: use waitid() over waitpid()" Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 23/32] tools/nolibc: add dprintf() and vdprintf() Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 24/32] tools/nolibc: add getopt() Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 25/32] tools/nolibc: allow different write callbacks in printf Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 26/32] tools/nolibc: allow limiting of printf destination size Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 27/32] tools/nolibc: add snprintf() and friends Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 28/32] selftests/nolibc: use snprintf() for printf tests Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 29/32] selftests/nolibc: rename vfprintf test suite Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 30/32] selftests/nolibc: add test for snprintf() truncation Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 31/32] tools/nolibc: implement width padding in printf() Thomas Weißschuh
2025-04-07  6:52 ` [PATCH v2 32/32] HACK: selftests/nolibc: demonstrate usage of the kselftest harness Thomas Weißschuh
2025-04-10 15:19 ` [PATCH v2 00/32] kselftest harness and nolibc compatibility Shuah Khan
2025-04-10 20:01   ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250407-nolibc-kselftest-harness-v2-4-f8812f76e930@linutronix.de \
    --to=thomas.weissschuh@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).