From: Jakub Kicinski <kuba@kernel.org>
To: David Wei <dw@davidwei.uk>
Cc: Mohsin Bashir <mohsin.bashr@gmail.com>,
netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
shuah@kernel.org, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com, ap420073@gmail.com,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net 3/3] selftests: drv: net: add version indicator
Date: Mon, 5 May 2025 10:49:54 -0700 [thread overview]
Message-ID: <20250505104954.39cc63e1@kernel.org> (raw)
In-Reply-To: <a8c17a58-67fe-4cba-ad4a-a1822554c459@davidwei.uk>
On Fri, 2 May 2025 22:02:43 -0700 David Wei wrote:
> > -def test_default(cfg, netnl) -> None:
> > +def test_default_v4(cfg, netnl) -> None:
> > + cfg.require_ipver("4")
>
> With this patch, is the previous patch and this hunk still needed? I
> think you can drop patch 2/3 or both.
The previous patch makes the more "meaty" tests run when either ipver
is available. But we still want an indication if both versions are
supported by env but reporting *a* skip. Historically this is what
the ping test was for, TBH, pretty much a sanity check for the env.
But it ended up accumulating random XDP test cases :(
Perhaps something to address in net-next..
next prev parent reply other threads:[~2025-05-05 17:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-03 1:35 [PATCH net 0/3 v4] selftests: drv: net: fix `ping.py` test failure Mohsin Bashir
2025-05-03 1:35 ` [PATCH net 1/3] selftests: drv: net: fix test failure on ipv6 sys Mohsin Bashir
2025-05-03 4:49 ` David Wei
2025-05-05 17:44 ` Jakub Kicinski
2025-05-03 1:35 ` [PATCH net 2/3] selftests: drv: net: avoid skipping tests Mohsin Bashir
2025-05-03 4:54 ` David Wei
2025-05-05 17:47 ` Jakub Kicinski
2025-05-05 18:12 ` David Wei
2025-05-05 18:19 ` David Wei
2025-05-03 1:35 ` [PATCH net 3/3] selftests: drv: net: add version indicator Mohsin Bashir
2025-05-03 5:02 ` David Wei
2025-05-05 17:49 ` Jakub Kicinski [this message]
2025-05-05 18:25 ` David Wei
2025-05-06 1:20 ` [PATCH net 0/3 v4] selftests: drv: net: fix `ping.py` test failure patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505104954.39cc63e1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ap420073@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).