* [PATCH v2] selftests/ftrace: Convert poll to a gen_file
@ 2025-04-09 4:46 Ayush Jain
2025-04-09 16:48 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Ayush Jain @ 2025-04-09 4:46 UTC (permalink / raw)
To: rostedt, mhiramat, mathieu.desnoyers, linux-kernel,
linux-trace-kernel, linux-kselftest
Cc: Naveen.Rao, Kalpana.Shetty, Narasimhan.V, Ayush Jain
Poll program is a helper to ftracetest, thus make it a
generic file and remove it from being run as a test.
Currently when executing tests using
$ make run_tests
CC poll
TAP version 13
1..2
# timeout set to 0
# selftests: ftrace: poll
# Error: Polling file is not specified
not ok 1 selftests: ftrace: poll # exit=255
Fix this by using TEST_GEN_FILES to build the 'poll' binary as a helper
rather than as a test.
Fixes: 80c3e28528ff ("selftests/tracing: Add hist poll() support test")
Signed-off-by: Ayush Jain <Ayush.jain3@amd.com>
---
tools/testing/selftests/ftrace/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile
index 49d96bb16355..7c12263f8260 100644
--- a/tools/testing/selftests/ftrace/Makefile
+++ b/tools/testing/selftests/ftrace/Makefile
@@ -6,6 +6,6 @@ TEST_PROGS := ftracetest-ktap
TEST_FILES := test.d settings
EXTRA_CLEAN := $(OUTPUT)/logs/*
-TEST_GEN_PROGS = poll
+TEST_GEN_FILES := poll
include ../lib.mk
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] selftests/ftrace: Convert poll to a gen_file
2025-04-09 4:46 [PATCH v2] selftests/ftrace: Convert poll to a gen_file Ayush Jain
@ 2025-04-09 16:48 ` Steven Rostedt
2025-05-07 19:26 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2025-04-09 16:48 UTC (permalink / raw)
To: Ayush Jain
Cc: mhiramat, mathieu.desnoyers, linux-kernel, linux-trace-kernel,
linux-kselftest, Naveen.Rao, Kalpana.Shetty, Narasimhan.V,
Shuah Khan
On Wed, 9 Apr 2025 04:46:32 +0000
Ayush Jain <Ayush.jain3@amd.com> wrote:
> Poll program is a helper to ftracetest, thus make it a
> generic file and remove it from being run as a test.
>
> Currently when executing tests using
> $ make run_tests
> CC poll
> TAP version 13
> 1..2
> # timeout set to 0
> # selftests: ftrace: poll
> # Error: Polling file is not specified
> not ok 1 selftests: ftrace: poll # exit=255
>
> Fix this by using TEST_GEN_FILES to build the 'poll' binary as a helper
> rather than as a test.
>
> Fixes: 80c3e28528ff ("selftests/tracing: Add hist poll() support test")
>
> Signed-off-by: Ayush Jain <Ayush.jain3@amd.com>
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
> ---
> tools/testing/selftests/ftrace/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile
> index 49d96bb16355..7c12263f8260 100644
> --- a/tools/testing/selftests/ftrace/Makefile
> +++ b/tools/testing/selftests/ftrace/Makefile
> @@ -6,6 +6,6 @@ TEST_PROGS := ftracetest-ktap
> TEST_FILES := test.d settings
> EXTRA_CLEAN := $(OUTPUT)/logs/*
>
> -TEST_GEN_PROGS = poll
> +TEST_GEN_FILES := poll
>
> include ../lib.mk
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] selftests/ftrace: Convert poll to a gen_file
2025-04-09 16:48 ` Steven Rostedt
@ 2025-05-07 19:26 ` Steven Rostedt
2025-05-09 17:03 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2025-05-07 19:26 UTC (permalink / raw)
To: Ayush Jain
Cc: mhiramat, mathieu.desnoyers, linux-kernel, linux-trace-kernel,
linux-kselftest, Naveen.Rao, Kalpana.Shetty, Narasimhan.V,
Shuah Khan
Shuah,
Can you take this through your tree?
-- Steve
On Wed, 9 Apr 2025 12:48:55 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 9 Apr 2025 04:46:32 +0000
> Ayush Jain <Ayush.jain3@amd.com> wrote:
>
> > Poll program is a helper to ftracetest, thus make it a
> > generic file and remove it from being run as a test.
> >
> > Currently when executing tests using
> > $ make run_tests
> > CC poll
> > TAP version 13
> > 1..2
> > # timeout set to 0
> > # selftests: ftrace: poll
> > # Error: Polling file is not specified
> > not ok 1 selftests: ftrace: poll # exit=255
> >
> > Fix this by using TEST_GEN_FILES to build the 'poll' binary as a helper
> > rather than as a test.
> >
> > Fixes: 80c3e28528ff ("selftests/tracing: Add hist poll() support test")
> >
> > Signed-off-by: Ayush Jain <Ayush.jain3@amd.com>
>
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>
> -- Steve
>
> > ---
> > tools/testing/selftests/ftrace/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile
> > index 49d96bb16355..7c12263f8260 100644
> > --- a/tools/testing/selftests/ftrace/Makefile
> > +++ b/tools/testing/selftests/ftrace/Makefile
> > @@ -6,6 +6,6 @@ TEST_PROGS := ftracetest-ktap
> > TEST_FILES := test.d settings
> > EXTRA_CLEAN := $(OUTPUT)/logs/*
> >
> > -TEST_GEN_PROGS = poll
> > +TEST_GEN_FILES := poll
> >
> > include ../lib.mk
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] selftests/ftrace: Convert poll to a gen_file
2025-05-07 19:26 ` Steven Rostedt
@ 2025-05-09 17:03 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2025-05-09 17:03 UTC (permalink / raw)
To: Steven Rostedt, Ayush Jain
Cc: mhiramat, mathieu.desnoyers, linux-kernel, linux-trace-kernel,
linux-kselftest, Naveen.Rao, Kalpana.Shetty, Narasimhan.V,
Shuah Khan
On 5/7/25 13:26, Steven Rostedt wrote:
>
> Shuah,
>
> Can you take this through your tree?
>
> -- Steve
>
>
> On Wed, 9 Apr 2025 12:48:55 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>> On Wed, 9 Apr 2025 04:46:32 +0000
>> Ayush Jain <Ayush.jain3@amd.com> wrote:
>>
>>> Poll program is a helper to ftracetest, thus make it a
>>> generic file and remove it from being run as a test.
>>>
>>> Currently when executing tests using
>>> $ make run_tests
>>> CC poll
>>> TAP version 13
>>> 1..2
>>> # timeout set to 0
>>> # selftests: ftrace: poll
>>> # Error: Polling file is not specified
>>> not ok 1 selftests: ftrace: poll # exit=255
>>>
>>> Fix this by using TEST_GEN_FILES to build the 'poll' binary as a helper
>>> rather than as a test.
>>>
>>> Fixes: 80c3e28528ff ("selftests/tracing: Add hist poll() support test")
>>>
>>> Signed-off-by: Ayush Jain <Ayush.jain3@amd.com>
>>
>> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>>
>> -- Steve
Yes - I will take this through my tree.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-09 17:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-09 4:46 [PATCH v2] selftests/ftrace: Convert poll to a gen_file Ayush Jain
2025-04-09 16:48 ` Steven Rostedt
2025-05-07 19:26 ` Steven Rostedt
2025-05-09 17:03 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).