From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C100C2C109B for ; Tue, 13 May 2025 16:36:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747154184; cv=none; b=fWE0qSzrEEpvVPCzxuPPQRI2qMVWArV5Ihkroyu5gihWTigO7gRKPGVkudi7MrCygskFId7sdcdfRRtL2yOHjWpA3o/+7+YkOMLMrrTJ4i4XXIxCy2hon0ERjHdHLuuLWdzATDK4fv0FcTZuSkFRu4zGzWMte4U6YzChFv2RrL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747154184; c=relaxed/simple; bh=ZrYbmGF9Kmk2f8doMmW6o5Bn88l1p4cbIN1d9jlqzhM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=RnJNgXU9FgFIfQ10hF/pPtKiark9oTKnTLzRNnjwNtej0jvVavFdAK0A2+OdB0534BZJ0r+uuPVkcUPb08EPtz/9vox5EuXZvS5RTBYyh/qS5hnBHO63g5tJcSb4DRNiG9j0lMjIJZHh3z4LcQQ8TjZsryMLTS5jIbDeupNn2K4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--tjmercier.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=NhSHRb6+; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--tjmercier.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NhSHRb6+" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-30aab0f21a3so5485963a91.3 for ; Tue, 13 May 2025 09:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747154182; x=1747758982; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=bJInbrku/09cHF/oH5BSTHkjglGFd/9hG0nOEU3OeAs=; b=NhSHRb6+XBMEuCtQrMgZZItCvkQZwMOSQPrgLt/PKUolXRExzFtlz0Ix1t9ByWskEZ 7NCPlGQmv3bxSxyiMsvCewk5jYvrcLc+uVNXFpEslyZ4NPOwxAtbQlDBen5E6cUPCR36 LPTviCVlO1WooI3bS7SwfEJ1FoJYuxq6YSLqJobzHruM+zlxqHeN4XoZjTd/i0sLMvAo pcH7lX/Igp+590o+AU+757opHjZmx3WcHw9ajrlO8OjkOZVVNmTAXlf0y6EoFa7xttqZ XZ4lhRaCuq1ThIny/sEKrKqnlXzdddqyAkjK0Ovu0Ux3af4+8SOx/nMb+7vDKlrOdWF8 euoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747154182; x=1747758982; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bJInbrku/09cHF/oH5BSTHkjglGFd/9hG0nOEU3OeAs=; b=RKYvIQPN/EeUqZkDlDUgSdSzL3PsL6k2W2GqGKMon2uDx8PVWZ5OGOMq2NsbTj4CSU /HOsRYSslnCI1JVCqEAIarK0XdbirB9RPAet5onLUKEumJYtLtx/NN3vz5wcFqUoRlvf +0i45485quMR9PwE8CLD6H0ITd0X+3E6A3GQSCYAWyq3gumxld9R2gRsLv1j++wtWKVx HbulIVVHTXsXw16KcA293uQ7A6MpRJyHivR1vg8pPo7ofPyBcd7Xupqx5kZ5LNRU9MfU hYksMDEpojjn9mNXQDaWL+1g7koYUdlsax0QiaxiQ8GRPsCVdA/AAzODWdpGS4AcUyrB LcTw== X-Forwarded-Encrypted: i=1; AJvYcCX7h+fr6s3W2IHSsF1fA0+y2jyGQqOK07MaTzjuihbg0eFZ+Sp8f6beAlk6CU9qU3VCIsPpHOYxbWWdYuN4xgo=@vger.kernel.org X-Gm-Message-State: AOJu0YzkSRLJd6e8DlZXeMENlhESn4vq4+itZbOQkSRXnkvNEDVGzF9g PANXhn9rusczSblfTfC+G41hIzVN5NHMpfmpCu+NFxxNQOq9xwt9x+tjHjsZ81ofIdW5BUFGpT8 ZfwUK3BMK433NDQ== X-Google-Smtp-Source: AGHT+IHhneD4zr7WSuOJgLofUb/3Z5dtiVrJin97Z8oGy4S5ShGg9Bbso1NwkoAuYXhYFy55j6c2aTgu2Bia62c= X-Received: from pjbph5.prod.google.com ([2002:a17:90b:3bc5:b0:30a:7da4:f075]) (user=tjmercier job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5111:b0:30c:5255:ffe2 with SMTP id 98e67ed59e1d1-30e2e5d60bcmr385220a91.2.1747154182186; Tue, 13 May 2025 09:36:22 -0700 (PDT) Date: Tue, 13 May 2025 16:36:00 +0000 In-Reply-To: <20250513163601.812317-1-tjmercier@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250513163601.812317-1-tjmercier@google.com> X-Mailer: git-send-email 2.49.0.1045.g170613ef41-goog Message-ID: <20250513163601.812317-5-tjmercier@google.com> Subject: [PATCH bpf-next v6 4/5] selftests/bpf: Add test for dmabuf_iter From: "T.J. Mercier" To: sumit.semwal@linaro.org, christian.koenig@amd.com, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, skhan@linuxfoundation.org, alexei.starovoitov@gmail.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, android-mm@google.com, simona@ffwll.ch, eddyz87@gmail.com, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, jolsa@kernel.org, mykolal@fb.com, shuah@kernel.org, song@kernel.org, "T.J. Mercier" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This test creates a udmabuf, and a dmabuf from the system dmabuf heap, and uses a BPF program that prints dmabuf metadata with the new dmabuf_iter to verify they can be found. Signed-off-by: T.J. Mercier Acked-by: Christian K=C3=B6nig --- tools/testing/selftests/bpf/config | 3 + .../selftests/bpf/prog_tests/dmabuf_iter.c | 244 ++++++++++++++++++ .../testing/selftests/bpf/progs/dmabuf_iter.c | 53 ++++ 3 files changed, 300 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c create mode 100644 tools/testing/selftests/bpf/progs/dmabuf_iter.c diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/b= pf/config index c378d5d07e02..2bdff2f3285f 100644 --- a/tools/testing/selftests/bpf/config +++ b/tools/testing/selftests/bpf/config @@ -22,6 +22,8 @@ CONFIG_CRYPTO_AES=3Dy CONFIG_DEBUG_INFO=3Dy CONFIG_DEBUG_INFO_BTF=3Dy CONFIG_DEBUG_INFO_DWARF4=3Dy +CONFIG_DMABUF_HEAPS=3Dy +CONFIG_DMABUF_HEAPS_SYSTEM=3Dy CONFIG_DUMMY=3Dy CONFIG_DYNAMIC_FTRACE=3Dy CONFIG_FPROBE=3Dy @@ -106,6 +108,7 @@ CONFIG_SECURITY=3Dy CONFIG_SECURITYFS=3Dy CONFIG_SYN_COOKIES=3Dy CONFIG_TEST_BPF=3Dm +CONFIG_UDMABUF=3Dy CONFIG_USERFAULTFD=3Dy CONFIG_VSOCKETS=3Dy CONFIG_VXLAN=3Dy diff --git a/tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c b/tools/t= esting/selftests/bpf/prog_tests/dmabuf_iter.c new file mode 100644 index 000000000000..dc740bd0e2bd --- /dev/null +++ b/tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c @@ -0,0 +1,244 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2025 Google */ + +#include +#include +#include +#include "dmabuf_iter.skel.h" + +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +static int udmabuf =3D -1; +static const char udmabuf_test_buffer_name[DMA_BUF_NAME_LEN] =3D "udmabuf_= test_buffer_for_iter"; +static size_t udmabuf_test_buffer_size; +static int sysheap_dmabuf =3D -1; +static const char sysheap_test_buffer_name[DMA_BUF_NAME_LEN] =3D "sysheap_= test_buffer_for_iter"; +static size_t sysheap_test_buffer_size; + +static int create_udmabuf(void) +{ + struct udmabuf_create create; + int dev_udmabuf, memfd, local_udmabuf; + + udmabuf_test_buffer_size =3D 10 * getpagesize(); + + if (!ASSERT_LE(sizeof(udmabuf_test_buffer_name), DMA_BUF_NAME_LEN, "NAMET= OOLONG")) + return -1; + + memfd =3D memfd_create("memfd_test", MFD_ALLOW_SEALING); + if (!ASSERT_OK_FD(memfd, "memfd_create")) + return -1; + + if (!ASSERT_OK(ftruncate(memfd, udmabuf_test_buffer_size), "ftruncate")) + goto close_memfd; + + if (!ASSERT_OK(fcntl(memfd, F_ADD_SEALS, F_SEAL_SHRINK), "seal")) + goto close_memfd; + + dev_udmabuf =3D open("/dev/udmabuf", O_RDONLY); + if (!ASSERT_OK_FD(dev_udmabuf, "open udmabuf")) + goto close_memfd; + + memset(&create, 0, sizeof(create)); + create.memfd =3D memfd; + create.flags =3D UDMABUF_FLAGS_CLOEXEC; + create.offset =3D 0; + create.size =3D udmabuf_test_buffer_size; + + local_udmabuf =3D ioctl(dev_udmabuf, UDMABUF_CREATE, &create); + close(dev_udmabuf); + if (!ASSERT_OK_FD(local_udmabuf, "udmabuf_create")) + goto close_memfd; + + if (!ASSERT_OK(ioctl(local_udmabuf, DMA_BUF_SET_NAME_B, udmabuf_test_buff= er_name), "name")) + goto close_udmabuf; + + return local_udmabuf; + +close_udmabuf: + close(local_udmabuf); +close_memfd: + close(memfd); + return -1; +} + +static int create_sys_heap_dmabuf(void) +{ + sysheap_test_buffer_size =3D 20 * getpagesize(); + + struct dma_heap_allocation_data data =3D { + .len =3D sysheap_test_buffer_size, + .fd =3D 0, + .fd_flags =3D O_RDWR | O_CLOEXEC, + .heap_flags =3D 0, + }; + int heap_fd, ret; + + if (!ASSERT_LE(sizeof(sysheap_test_buffer_name), DMA_BUF_NAME_LEN, "NAMET= OOLONG")) + return -1; + + heap_fd =3D open("/dev/dma_heap/system", O_RDONLY); + if (!ASSERT_OK_FD(heap_fd, "open dma heap")) + return -1; + + ret =3D ioctl(heap_fd, DMA_HEAP_IOCTL_ALLOC, &data); + close(heap_fd); + if (!ASSERT_OK(ret, "syheap alloc")) + return -1; + + if (!ASSERT_OK(ioctl(data.fd, DMA_BUF_SET_NAME_B, sysheap_test_buffer_nam= e), "name")) + goto close_sysheap_dmabuf; + + return data.fd; + +close_sysheap_dmabuf: + close(data.fd); + return -1; +} + +static int create_test_buffers(void) +{ + udmabuf =3D create_udmabuf(); + sysheap_dmabuf =3D create_sys_heap_dmabuf(); + + if (udmabuf < 0 || sysheap_dmabuf < 0) + return -1; + + return 0; +} + +static void destroy_test_buffers(void) +{ + close(udmabuf); + udmabuf =3D -1; + + close(sysheap_dmabuf); + sysheap_dmabuf =3D -1; +} + +enum Fields { INODE, SIZE, NAME, EXPORTER, FIELD_COUNT }; +struct DmabufInfo { + unsigned long inode; + unsigned long size; + char name[DMA_BUF_NAME_LEN]; + char exporter[32]; +}; + +static bool check_dmabuf_info(const struct DmabufInfo *bufinfo, + unsigned long size, + const char *name, const char *exporter) +{ + return size =3D=3D bufinfo->size && + !strcmp(name, bufinfo->name) && + !strcmp(exporter, bufinfo->exporter); +} + +static void subtest_dmabuf_iter_check_no_infinite_reads(struct dmabuf_iter= *skel) +{ + int iter_fd; + char buf[256]; + + iter_fd =3D bpf_iter_create(bpf_link__fd(skel->links.dmabuf_collector)); + if (!ASSERT_OK_FD(iter_fd, "iter_create")) + return; + + while (read(iter_fd, buf, sizeof(buf)) > 0) + ; /* Read out all contents */ + + /* Next reads should return 0 */ + ASSERT_EQ(read(iter_fd, buf, sizeof(buf)), 0, "read"); + + close(iter_fd); +} + +static void subtest_dmabuf_iter_check_default_iter(struct dmabuf_iter *ske= l) +{ + bool found_test_sysheap_dmabuf =3D false; + bool found_test_udmabuf =3D false; + struct DmabufInfo bufinfo; + size_t linesize =3D 0; + char *line =3D NULL; + FILE *iter_file; + int iter_fd, f =3D INODE; + + iter_fd =3D bpf_iter_create(bpf_link__fd(skel->links.dmabuf_collector)); + if (!ASSERT_OK_FD(iter_fd, "iter_create")) + return; + + iter_file =3D fdopen(iter_fd, "r"); + if (!ASSERT_OK_PTR(iter_file, "fdopen")) + goto close_iter_fd; + + while (getline(&line, &linesize, iter_file) !=3D -1) { + if (f % FIELD_COUNT =3D=3D INODE) { + ASSERT_EQ(sscanf(line, "%ld", &bufinfo.inode), 1, + "read inode"); + } else if (f % FIELD_COUNT =3D=3D SIZE) { + ASSERT_EQ(sscanf(line, "%ld", &bufinfo.size), 1, + "read size"); + } else if (f % FIELD_COUNT =3D=3D NAME) { + ASSERT_EQ(sscanf(line, "%s", bufinfo.name), 1, + "read name"); + } else if (f % FIELD_COUNT =3D=3D EXPORTER) { + ASSERT_EQ(sscanf(line, "%31s", bufinfo.exporter), 1, + "read exporter"); + + if (check_dmabuf_info(&bufinfo, + sysheap_test_buffer_size, + sysheap_test_buffer_name, + "system")) + found_test_sysheap_dmabuf =3D true; + else if (check_dmabuf_info(&bufinfo, + udmabuf_test_buffer_size, + udmabuf_test_buffer_name, + "udmabuf")) + found_test_udmabuf =3D true; + } + ++f; + } + + ASSERT_EQ(f % FIELD_COUNT, INODE, "number of fields"); + + ASSERT_TRUE(found_test_sysheap_dmabuf, "found_test_sysheap_dmabuf"); + ASSERT_TRUE(found_test_udmabuf, "found_test_udmabuf"); + + free(line); + fclose(iter_file); +close_iter_fd: + close(iter_fd); +} + +void test_dmabuf_iter(void) +{ + struct dmabuf_iter *skel =3D NULL; + + skel =3D dmabuf_iter__open_and_load(); + if (!ASSERT_OK_PTR(skel, "dmabuf_iter__open_and_load")) + return; + + if (!ASSERT_OK(create_test_buffers(), "create_test_buffers")) + goto destroy; + + if (!ASSERT_OK(dmabuf_iter__attach(skel), "skel_attach")) + goto destroy; + + if (test__start_subtest("no_infinite_reads")) + subtest_dmabuf_iter_check_no_infinite_reads(skel); + if (test__start_subtest("default_iter")) + subtest_dmabuf_iter_check_default_iter(skel); + +destroy: + destroy_test_buffers(); + dmabuf_iter__destroy(skel); +} diff --git a/tools/testing/selftests/bpf/progs/dmabuf_iter.c b/tools/testin= g/selftests/bpf/progs/dmabuf_iter.c new file mode 100644 index 000000000000..2a1b5397196d --- /dev/null +++ b/tools/testing/selftests/bpf/progs/dmabuf_iter.c @@ -0,0 +1,53 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2025 Google LLC */ +#include +#include +#include + +/* From uapi/linux/dma-buf.h */ +#define DMA_BUF_NAME_LEN 32 + +char _license[] SEC("license") =3D "GPL"; + +/* + * Fields output by this iterator are delimited by newlines. Convert any + * newlines in user-provided printed strings to spaces. + */ +static void sanitize_string(char *src, size_t size) +{ + for (char *c =3D src; *c && (size_t)(c - src) < size; ++c) + if (*c =3D=3D '\n') + *c =3D ' '; +} + +SEC("iter/dmabuf") +int dmabuf_collector(struct bpf_iter__dmabuf *ctx) +{ + const struct dma_buf *dmabuf =3D ctx->dmabuf; + struct seq_file *seq =3D ctx->meta->seq; + unsigned long inode =3D 0; + size_t size; + const char *pname, *exporter; + char name[DMA_BUF_NAME_LEN] =3D {'\0'}; + + if (!dmabuf) + return 0; + + if (BPF_CORE_READ_INTO(&inode, dmabuf, file, f_inode, i_ino) || + bpf_core_read(&size, sizeof(size), &dmabuf->size) || + bpf_core_read(&pname, sizeof(pname), &dmabuf->name) || + bpf_core_read(&exporter, sizeof(exporter), &dmabuf->exp_name)) + return 1; + + /* Buffers are not required to be named */ + if (pname) { + if (bpf_probe_read_kernel(name, sizeof(name), pname)) + return 1; + + /* Name strings can be provided by userspace */ + sanitize_string(name, sizeof(name)); + } + + BPF_SEQ_PRINTF(seq, "%lu\n%llu\n%s\n%s\n", inode, size, name, exporter); + return 0; +} --=20 2.49.0.1045.g170613ef41-goog