From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <stfomichev@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
jiri@resnulli.us, shuah@kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: net: validate team flags propagation
Date: Fri, 16 May 2025 07:35:56 -0700 [thread overview]
Message-ID: <20250516073556.5983d1d0@kernel.org> (raw)
In-Reply-To: <20250515231332.4120071-1-stfomichev@gmail.com>
On Thu, 15 May 2025 16:13:32 -0700 Stanislav Fomichev wrote:
> Cover three recent cases:
> 1. missing ops locking for the lowers during netdev_sync_lower_features
> 2. missing locking for dev_set_promiscuity (plus netdev_ops_assert_locked
> with a comment on why/when it's needed)
> 3. rcu lock during team_change_rx_flags
>
> Verified that each one triggers when the respective fix is reverted.
> Not sure about the placement, but since it all relies on teaming,
> added to the teaming directory.
>
> One ugly bit is that I add NETIF_F_LRO to netdevsim; there is no way
> to trigger netdev_sync_lower_features without it.
Seems to consistently fail in NIPA :(
--
pw-bot: cr
next prev parent reply other threads:[~2025-05-16 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 23:13 [PATCH net] selftests: net: validate team flags propagation Stanislav Fomichev
2025-05-16 14:35 ` Jakub Kicinski [this message]
2025-05-16 17:51 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250516073556.5983d1d0@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=stfomichev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).