From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50E281DB124; Tue, 20 May 2025 22:59:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747781999; cv=none; b=toGWpqHJ+Cvp8GcCk0QjluXksoxRDOIcJL4TyZCOeQ8tsWp9hWxGrJXOxRfqXPxkl76yNmgWvFUHdJNVL/xWaBXUMCJZyqtbXAaLcKvnBn+kKsRbfJO4GsymaW4Qf2DyuLj5RQusWaSX9xUCAOpTTkCDYFcIwjEh4rz7CC964fk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747781999; c=relaxed/simple; bh=gTQNvf/9cpbAN7wF1rSo4wWYuMaNi88KIdv6xt3mwn8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Em1LmTlqXWBBA0b9qtv4q58VrjDHUSD7dhlOwdZpOOG9YDHxZOzd3P3yRUb7TxM+Qwija7bK8FAujycn0o9QKv9JGeGsUEcc5zPQ6eCqme1s9fQBtbwYwYr4BlSi+deItugJPgMvnK7W/1R1LmVm67PDDh4uCtxsdQvD7FUqykE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XlQooxPY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XlQooxPY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2AFDC4CEE9; Tue, 20 May 2025 22:59:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747781998; bh=gTQNvf/9cpbAN7wF1rSo4wWYuMaNi88KIdv6xt3mwn8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XlQooxPYVVVdZZ6A7SEzxhWExRGuUo8AKbYZbrxl7vewcyVbEZMZnuynUp8lY83dO Q8Eygf4ZOlO+TqNutNFj5r7rKZDlYZpw/gUkY/Hsg53v2OvvzUFsDFB1KhSMP5gwkr NV3C++V2YfjE8aQ5Fr8SlSLD7cfVJuye0u+h4mPISHfSd4LDVGMnaLQdDBk2m3oBrs 091wa7fdXLyChefd5vyvMN9HV51yYSdf+Ohy6bckFHDM+A1/d1jFAKEEUG2Ho10GQA LgpEMry2QdE6n/hGgsDGnhVy2/NEalntLREDqstPDTTF1JtEsjtuUfuUlvO0lvKVTq 1cmSj1LVvpgXg== Date: Tue, 20 May 2025 15:59:57 -0700 From: Jakub Kicinski To: Carolina Jubran Cc: Tariq Toukan , "David S. Miller" , Paolo Abeni , Eric Dumazet , "Andrew Lunn" , Jiri Pirko , Gal Pressman , "Leon Romanovsky" , Donald Hunter , "Jiri Pirko" , Jonathan Corbet , Saeed Mahameed , Leon Romanovsky , Shuah Khan , , , , , , "Moshe Shemesh" , Mark Bloch , Cosmin Ratiu Subject: Re: [PATCH net-next V10 2/6] selftest: netdevsim: Add devlink rate tc-bw test Message-ID: <20250520155957.04b27217@kernel.org> In-Reply-To: <1747766287-950144-3-git-send-email-tariqt@nvidia.com> References: <1747766287-950144-1-git-send-email-tariqt@nvidia.com> <1747766287-950144-3-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 20 May 2025 21:38:03 +0300 Tariq Toukan wrote: > Test verifies that netdevsim correctly implements devlink ops callbacks > that set tc-bw on leaf or node rate object. Please add a test that can actually validate a NIC HW. The test probably needs to be in Python to use a remote endpoint, and should live under tools/testing/../drivers/net/hw We had a long conversation about what we expect from the API vs how your HW works. One of the test cases should confirm the expected behavior, IOW fail on mlx5. Which is fine, unlikely that any NIC will have 100% compliance. But at least we will be documenting the expectations.