linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] selftests/filesystems: Fix build of anon_inode_test
@ 2025-05-30 10:42 Mark Brown
  2025-06-02 22:33 ` Shuah Khan
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2025-05-30 10:42 UTC (permalink / raw)
  To: Linus Torvalds, Shuah Khan, Christian Brauner, Jeff Layton,
	Amir Goldstein
  Cc: linux-kselftest, linux-kernel, Mark Brown

The newly added anon_inode_test test fails to build due to attempting to
include a nonexisting overlayfs/wrapper.h:

anon_inode_test.c:10:10: fatal error: overlayfs/wrappers.h: No such file or directory
   10 | #include "overlayfs/wrappers.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~

This is due to 0bd92b9fe538 ("selftests/filesystems: move wrapper.h out
of overlayfs subdir") which was added in the vfs-6.16.selftests branch
which was based on -rc5 and did not contain the newly added test so once
things were merged into mainline the build started failing - both
parent commits are fine.

Fixes: 3e406741b1989 ("Merge tag 'vfs-6.16-rc1.selftests' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs")
Signed-off-by: Mark Brown <broonie@kernel.org>
---
Changes in v2:
- Rebase onto mainline and adjust fixes commit now the two branches got
  merged there.
- Link to v1: https://lore.kernel.org/r/20250518-selftests-anon-inode-build-v1-1-71eff8183168@kernel.org
---
 tools/testing/selftests/filesystems/anon_inode_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/filesystems/anon_inode_test.c b/tools/testing/selftests/filesystems/anon_inode_test.c
index e8e0ef1460d2..73e0a4d4fb2f 100644
--- a/tools/testing/selftests/filesystems/anon_inode_test.c
+++ b/tools/testing/selftests/filesystems/anon_inode_test.c
@@ -7,7 +7,7 @@
 #include <sys/stat.h>
 
 #include "../kselftest_harness.h"
-#include "overlayfs/wrappers.h"
+#include "wrappers.h"
 
 TEST(anon_inode_no_chown)
 {

---
base-commit: f66bc387efbee59978e076ce9bf123ac353b389c
change-id: 20250516-selftests-anon-inode-build-007e206e8422

Best regards,
-- 
Mark Brown <broonie@kernel.org>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] selftests/filesystems: Fix build of anon_inode_test
  2025-05-30 10:42 [PATCH v2] selftests/filesystems: Fix build of anon_inode_test Mark Brown
@ 2025-06-02 22:33 ` Shuah Khan
  0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2025-06-02 22:33 UTC (permalink / raw)
  To: Mark Brown, Linus Torvalds, Shuah Khan, Christian Brauner,
	Jeff Layton, Amir Goldstein
  Cc: linux-kselftest, linux-kernel, Shuah Khan

On 5/30/25 04:42, Mark Brown wrote:
> The newly added anon_inode_test test fails to build due to attempting to
> include a nonexisting overlayfs/wrapper.h:
> 
> anon_inode_test.c:10:10: fatal error: overlayfs/wrappers.h: No such file or directory
>     10 | #include "overlayfs/wrappers.h"
>        |          ^~~~~~~~~~~~~~~~~~~~~~
> 
> This is due to 0bd92b9fe538 ("selftests/filesystems: move wrapper.h out
> of overlayfs subdir") which was added in the vfs-6.16.selftests branch
> which was based on -rc5 and did not contain the newly added test so once
> things were merged into mainline the build started failing - both
> parent commits are fine.
> 
> Fixes: 3e406741b1989 ("Merge tag 'vfs-6.16-rc1.selftests' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs")
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> Changes in v2:
> - Rebase onto mainline and adjust fixes commit now the two branches got
>    merged there.
> - Link to v1: https://lore.kernel.org/r/20250518-selftests-anon-inode-build-v1-1-71eff8183168@kernel.org

Looks this will have to go directly to Linu's tree or vfs tree.

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-06-02 22:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-30 10:42 [PATCH v2] selftests/filesystems: Fix build of anon_inode_test Mark Brown
2025-06-02 22:33 ` Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).