From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
Joe Damato <jdamato@fastly.com>,
linux-kselftest@vger.kernel.org, Nimrod Oren <noren@nvidia.com>
Subject: Re: [PATCH net v2 2/2] selftests: drv-net: rss_ctx: Add test for ntuple rules targeting default RSS context
Date: Wed, 11 Jun 2025 08:52:08 -0700 [thread overview]
Message-ID: <20250611085208.42cb7271@kernel.org> (raw)
In-Reply-To: <1f1ecf24-9be1-4822-83f2-104420d39933@nvidia.com>
On Wed, 11 Jun 2025 08:06:38 +0300 Gal Pressman wrote:
> > tools/testing/selftests/drivers/net/hw/rss_ctx.py:788:0: C0301: Line too long (103/100) (line-too-long)
>
> Are you sure you want to blindly break this line?
> It's a single string.
Yeah, if it's a string leave it be. This one is just a check, the other
one as a warning. Unhelpfully I don't see an option in pylint to add the
bad lines to the report so its a bit hard to tell at a glance. The long
strings and the lack of doc string in the main function are the two
checks that we are definitely okay to ignore.
prev parent reply other threads:[~2025-06-11 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 12:02 [PATCH net v2 0/2] Fix ntuple rules targeting default RSS Gal Pressman
2025-06-09 12:02 ` [PATCH net v2 1/2] net: ethtool: Don't check if RSS context exists in case of context 0 Gal Pressman
2025-06-09 15:38 ` Subbaraya Sundeep
2025-06-09 22:41 ` Jakub Kicinski
2025-06-10 5:58 ` Gal Pressman
2025-06-10 21:33 ` Jakub Kicinski
2025-06-09 12:02 ` [PATCH net v2 2/2] selftests: drv-net: rss_ctx: Add test for ntuple rules targeting default RSS context Gal Pressman
2025-06-10 21:32 ` Jakub Kicinski
2025-06-11 5:06 ` Gal Pressman
2025-06-11 15:52 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611085208.42cb7271@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).