From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <stfomichev@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, skalluru@marvell.com, manishc@marvell.com,
andrew+netdev@lunn.ch, michael.chan@broadcom.com,
pavan.chebbi@broadcom.com, ajit.khaparde@broadcom.com,
sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
tariqt@nvidia.com, saeedm@nvidia.com, louis.peens@corigine.com,
shshaikh@marvell.com, GR-Linux-NIC-Dev@marvell.com,
ecree.xilinx@gmail.com, horms@kernel.org, dsahern@kernel.org,
shuah@kernel.org, ruanjinjie@huawei.com, mheib@redhat.com,
linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-rdma@vger.kernel.org, oss-drivers@corigine.com,
linux-net-drivers@amd.com, linux-kselftest@vger.kernel.org,
leon@kernel.org, Cosmin Ratiu <cratiu@nvidia.com>
Subject: Re: [PATCH net-next v3 1/4] udp_tunnel: remove rtnl_lock dependency
Date: Wed, 11 Jun 2025 18:43:45 -0700 [thread overview]
Message-ID: <20250611184345.3b403ad0@kernel.org> (raw)
In-Reply-To: <20250610171522.2119030-2-stfomichev@gmail.com>
On Tue, 10 Jun 2025 10:15:19 -0700 Stanislav Fomichev wrote:
> Drivers that are using ops lock and don't depend on RTNL lock
> still need to manage it because udp_tunnel's RTNL dependency.
> Introduce new udp_tunnel_nic_lock and use it instead of
> rtnl_lock. Drop non-UDP_TUNNEL_NIC_INFO_MAY_SLEEP mode from
> udp_tunnel infra (udp_tunnel_nic_device_sync_work needs to
> grab udp_tunnel_nic_lock mutex and might sleep).
There are multiple entry points to this code, basically each member of
struct udp_tunnel_nic_ops and the netdev notifiers. In this patch only
reset and work are locked. I'm a bit confused as to what is the new
lock protecting :S
next prev parent reply other threads:[~2025-06-12 1:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 17:15 [PATCH net-next v3 0/4] udp_tunnel: remove rtnl_lock dependency Stanislav Fomichev
2025-06-10 17:15 ` [PATCH net-next v3 1/4] " Stanislav Fomichev
2025-06-12 1:43 ` Jakub Kicinski [this message]
2025-06-12 2:47 ` Stanislav Fomichev
2025-06-12 14:39 ` Jakub Kicinski
2025-06-10 17:15 ` [PATCH net-next v3 2/4] net: remove redundant ASSERT_RTNL() in queue setup functions Stanislav Fomichev
2025-06-11 7:24 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-06-10 17:15 ` [PATCH net-next v3 3/4] netdevsim: remove udp_ports_sleep Stanislav Fomichev
2025-06-10 17:15 ` [PATCH net-next v3 4/4] Revert "bnxt_en: bring back rtnl_lock() in the bnxt_open() path" Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611184345.3b403ad0@kernel.org \
--to=kuba@kernel.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=linux-rdma@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=manishc@marvell.com \
--cc=mheib@redhat.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=ruanjinjie@huawei.com \
--cc=saeedm@nvidia.com \
--cc=shshaikh@marvell.com \
--cc=shuah@kernel.org \
--cc=skalluru@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=stfomichev@gmail.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).