From: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
To: Luis Chamberlain <mcgrof@kernel.org>,
Petr Pavlu <petr.pavlu@suse.com>,
Sami Tolvanen <samitolvanen@google.com>,
Daniel Gomez <da.gomez@samsung.com>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>
Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Subject: [PATCH 1/3] module: move 'struct module_use' to internal.h
Date: Thu, 12 Jun 2025 16:53:54 +0200 [thread overview]
Message-ID: <20250612-kunit-ifdef-modules-v1-1-fdccd42dcff8@linutronix.de> (raw)
In-Reply-To: <20250612-kunit-ifdef-modules-v1-0-fdccd42dcff8@linutronix.de>
The struct was moved to the public header file in
commit c8e21ced08b3 ("module: fix kdb's illicit use of struct module_use.").
Back then the structure was used outside of the module core.
Nowadays this is not true anymore, so the structure can be made internal.
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
include/linux/module.h | 7 -------
kernel/module/internal.h | 7 +++++++
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/linux/module.h b/include/linux/module.h
index 92e1420fccdffc9de9f49da9061546cc1e0c89d1..52f7b0487a2733c56e2531a434887e56e1bf45b2 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -313,13 +313,6 @@ void *__symbol_get_gpl(const char *symbol);
__used __section(".no_trim_symbol") = __stringify(x); \
(typeof(&x))(__symbol_get(__stringify(x))); })
-/* modules using other modules: kdb wants to see this. */
-struct module_use {
- struct list_head source_list;
- struct list_head target_list;
- struct module *source, *target;
-};
-
enum module_state {
MODULE_STATE_LIVE, /* Normal state. */
MODULE_STATE_COMING, /* Full formed, running module_init. */
diff --git a/kernel/module/internal.h b/kernel/module/internal.h
index 8d74b0a21c82b5360977a29736eca78ee6b6be3e..1c2e0b0dc52e72d5ecd2f1b310ce535364b3f33b 100644
--- a/kernel/module/internal.h
+++ b/kernel/module/internal.h
@@ -109,6 +109,13 @@ struct find_symbol_arg {
enum mod_license license;
};
+/* modules using other modules */
+struct module_use {
+ struct list_head source_list;
+ struct list_head target_list;
+ struct module *source, *target;
+};
+
int mod_verify_sig(const void *mod, struct load_info *info);
int try_to_force_load(struct module *mod, const char *reason);
bool find_symbol(struct find_symbol_arg *fsa);
--
2.49.0
next prev parent reply other threads:[~2025-06-12 14:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 14:53 [PATCH 0/3] module: make structure definitions always visible Thomas Weißschuh
2025-06-12 14:53 ` Thomas Weißschuh [this message]
2025-06-17 7:38 ` [PATCH 1/3] module: move 'struct module_use' to internal.h Petr Pavlu
2025-06-19 16:27 ` Daniel Gomez
2025-06-12 14:53 ` [PATCH 2/3] module: make structure definitions always visible Thomas Weißschuh
2025-07-07 19:11 ` Daniel Gomez
2025-07-08 9:32 ` Petr Pavlu
2025-07-11 6:29 ` Thomas Weißschuh
2025-07-11 13:24 ` Daniel Gomez
2025-07-08 9:39 ` Petr Pavlu
2025-06-12 14:53 ` [PATCH 3/3] kunit: test: Drop CONFIG_MODULE ifdeffery Thomas Weißschuh
2025-06-17 7:44 ` Petr Pavlu
2025-06-17 8:39 ` Thomas Weißschuh
2025-06-17 15:07 ` Petr Pavlu
2025-06-20 9:51 ` David Gow
2025-07-11 13:25 ` Daniel Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250612-kunit-ifdef-modules-v1-1-fdccd42dcff8@linutronix.de \
--to=thomas.weissschuh@linutronix.de \
--cc=brendan.higgins@linux.dev \
--cc=da.gomez@samsung.com \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=rmoar@google.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).