From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH net-next v2 7/7] selftest: netconsole: add test for cmdline configuration
Date: Thu, 12 Jun 2025 15:05:42 -0700 [thread overview]
Message-ID: <20250612150542.0b4a7d71@kernel.org> (raw)
In-Reply-To: <20250611-rework-v2-7-ab1d92b458ca@debian.org>
On Wed, 11 Jun 2025 07:18:56 -0700 Breno Leitao wrote:
> Add a new selftest to verify netconsole module loading with command
> line arguments. This test exercises the init_netconsole() path and
> validates proper parsing of the netconsole= parameter format.
>
> The test:
> - Loads netconsole module with cmdline configuration instead of
> dynamic reconfiguration
> - Validates message transmission through the configured target
> - Adds helper functions for cmdline string generation and module
> validation
>
> This complements existing netconsole selftests by covering the
> module initialization code path that processes boot-time parameters.
> This test is useful to test issues like the one described in [1].
I think this leaks the IP address, because if netcons_overflow.sh
runs afterwards it skips with:
# inet 192.0.2.1/24 scope global eni370np1
# SKIP: IPs already in use. Skipping it
if netcons_overflow.sh runs first everything is fine.
--
pw-bot: cr
next prev parent reply other threads:[~2025-06-12 22:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 14:18 [PATCH net-next v2 0/7] netpoll: Untangle netconsole and netpoll Breno Leitao
2025-06-11 14:18 ` [PATCH net-next v2 1/7] netpoll: remove __netpoll_cleanup from exported API Breno Leitao
2025-06-11 14:18 ` [PATCH net-next v2 2/7] netpoll: expose netpoll logging macros in public header Breno Leitao
2025-06-11 14:18 ` [PATCH net-next v2 3/7] netpoll: relocate netconsole-specific functions to netconsole module Breno Leitao
2025-06-11 14:18 ` [PATCH net-next v2 4/7] netpoll: move netpoll_print_options to netconsole Breno Leitao
2025-06-11 14:18 ` [PATCH net-next v2 5/7] netconsole: rename functions to better reflect their purpose Breno Leitao
2025-06-11 14:18 ` [PATCH net-next v2 6/7] netconsole: improve code style in parser function Breno Leitao
2025-06-11 14:18 ` [PATCH net-next v2 7/7] selftest: netconsole: add test for cmdline configuration Breno Leitao
2025-06-12 22:05 ` Jakub Kicinski [this message]
2025-06-13 11:22 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250612150542.0b4a7d71@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).