From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH net-next v1 2/4] netmem: fix netmem comments
Date: Sat, 14 Jun 2025 11:39:31 -0700 [thread overview]
Message-ID: <20250614113931.26dbbc53@kernel.org> (raw)
In-Reply-To: <20250613042804.3259045-2-almasrymina@google.com>
On Fri, 13 Jun 2025 04:28:02 +0000 Mina Almasry wrote:
> +/* __netmem_clear_lsb - clear the lsb of &netmem and return it as
> + * a net_iov*.
nit: "clear the lsb" spells out the name of the function..
how about: convert netmem_ref to struct net_iov * for metadata access
or some such ?
> + * @netmem: netmem reference to extract as net_iov.
next prev parent reply other threads:[~2025-06-14 18:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 4:28 [PATCH net-next v1 1/4] net: netmem: fix skb_ensure_writable with unreadable skbs Mina Almasry
2025-06-13 4:28 ` [PATCH net-next v1 2/4] netmem: fix netmem comments Mina Almasry
2025-06-14 18:39 ` Jakub Kicinski [this message]
2025-06-13 4:28 ` [PATCH net-next v1 3/4] selftests: devmem: remove unused variable Mina Almasry
2025-06-13 4:28 ` [PATCH net-next v1 4/4] selftests: devmem: add ipv4 support to chunks test Mina Almasry
2025-06-14 18:37 ` [PATCH net-next v1 1/4] net: netmem: fix skb_ensure_writable with unreadable skbs Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250614113931.26dbbc53@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).