From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: "Jesper Dangaard Brouer" <hawk@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Shuah Khan" <shuah@kernel.org>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Ignat Korchagin" <ignat@cloudflare.com>
Subject: Re: [PATCH net-next v4] page_pool: import Jesper's page_pool benchmark
Date: Thu, 19 Jun 2025 09:58:35 -0700 [thread overview]
Message-ID: <20250619095835.6ef52aee@kernel.org> (raw)
In-Reply-To: <CAHS8izOQLvPAE_E2dgMS7-11ZGFK5jmZ7q58LZCnhymhhUj2bQ@mail.gmail.com>
On Thu, 19 Jun 2025 08:37:05 -0700 Mina Almasry wrote:
> Jakub, this patch was marked 'changes requested' for good reason, but
> after investigation we found the patch itself is good and the issues
> were elsewhere. What do I do here? A resend of v4? Or does this un
> 'changes requested' as-is?
Do you want to update the numbers in the commit msg?
next prev parent reply other threads:[~2025-06-19 16:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-15 20:59 [PATCH net-next v4] page_pool: import Jesper's page_pool benchmark Mina Almasry
2025-06-16 9:29 ` Jesper Dangaard Brouer
2025-06-16 21:11 ` Mina Almasry
2025-06-18 12:46 ` Jesper Dangaard Brouer
2025-06-19 4:19 ` Mina Almasry
2025-06-19 10:24 ` Jesper Dangaard Brouer
2025-06-19 15:37 ` Mina Almasry
2025-06-19 16:58 ` Jakub Kicinski [this message]
2025-06-19 17:05 ` Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250619095835.6ef52aee@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ignat@cloudflare.com \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).