Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Achill Gilgenast <fossdd@pwned.life>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [RESEND PATCH v2] kallsyms: fix build without execinfo
Date: Sun, 22 Jun 2025 11:36:02 -0700	[thread overview]
Message-ID: <20250622113602.48092b368afc5f1729b45cb6@linux-foundation.org> (raw)
In-Reply-To: <20250622014608.448718-1-fossdd@pwned.life>

On Sun, 22 Jun 2025 03:45:49 +0200 Achill Gilgenast <fossdd@pwned.life> wrote:

> Some libc's like musl libc don't provide execinfo.h since it's not part
> of POSIX. In order to fix compilation on musl, only include execinfo.h
> if available (HAVE_BACKTRACE_SUPPORT)
> 
> This was discovered with c104c16073b7 ("Kunit to check the longest symbol length")
> which starts to include linux/kallsyms.h with Alpine Linux' configs.
> 
> ...
>
> --- a/tools/include/linux/kallsyms.h
> +++ b/tools/include/linux/kallsyms.h
> @@ -18,6 +18,7 @@ static inline const char *kallsyms_lookup(unsigned long addr,
>  	return NULL;
>  }
>  
> +#ifdef HAVE_BACKTRACE_SUPPORT
>  #include <execinfo.h>
>  #include <stdlib.h>
>  static inline void print_ip_sym(const char *loglvl, unsigned long ip)

I'm not seeing anything in there which needs execinfo.h.  Can we simply
remove the inclusion?



  reply	other threads:[~2025-06-22 18:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-22  1:45 [RESEND PATCH v2] kallsyms: fix build without execinfo Achill Gilgenast
2025-06-22 18:36 ` Andrew Morton [this message]
2025-06-23 11:53   ` Achill Gilgenast
2025-07-01 11:37     ` Achill Gilgenast
2025-07-01 16:19       ` Luis Henriques
2025-07-01 19:09         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250622113602.48092b368afc5f1729b45cb6@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=fossdd@pwned.life \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox