From: Jesse Taube <jesse@rivosinc.com>
To: kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
linux-kselftest@vger.kernel.org
Cc: "Clément Léger" <cleger@rivosinc.com>,
"Charlie Jenkins" <charlie@rivosinc.com>,
"Jesse Taube" <jesse@rivosinc.com>,
"Andrew Jones" <andrew.jones@linux.dev>,
"James Raphael Tiovalen" <jamestiotio@gmail.com>,
"Sean Christopherson" <seanjc@google.com>,
"Cade Richard" <cade.richard@gmail.com>
Subject: [kvm-unit-tests PATCH v2] riscv: lib: sbi_shutdown add pass/fail exit code.
Date: Tue, 24 Jun 2025 12:23:17 -0700 [thread overview]
Message-ID: <20250624192317.278437-1-jesse@rivosinc.com> (raw)
When exiting it may be useful for the sbi implementation to know if
kvm-unit-tests passed or failed.
Add exit code to sbi_shutdown, and use it in exit() to pass
success/failure (0/1) to sbi.
Signed-off-by: Jesse Taube <jesse@rivosinc.com>
---
lib/riscv/asm/sbi.h | 2 +-
lib/riscv/io.c | 2 +-
lib/riscv/sbi.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/riscv/asm/sbi.h b/lib/riscv/asm/sbi.h
index a5738a5c..de11c109 100644
--- a/lib/riscv/asm/sbi.h
+++ b/lib/riscv/asm/sbi.h
@@ -250,7 +250,7 @@ struct sbiret sbi_ecall(int ext, int fid, unsigned long arg0,
unsigned long arg3, unsigned long arg4,
unsigned long arg5);
-void sbi_shutdown(void);
+void sbi_shutdown(unsigned int code);
struct sbiret sbi_hart_start(unsigned long hartid, unsigned long entry, unsigned long sp);
struct sbiret sbi_hart_stop(void);
struct sbiret sbi_hart_get_status(unsigned long hartid);
diff --git a/lib/riscv/io.c b/lib/riscv/io.c
index fb40adb7..0bde25d4 100644
--- a/lib/riscv/io.c
+++ b/lib/riscv/io.c
@@ -150,7 +150,7 @@ void halt(int code);
void exit(int code)
{
printf("\nEXIT: STATUS=%d\n", ((code) << 1) | 1);
- sbi_shutdown();
+ sbi_shutdown(!!code);
halt(code);
__builtin_unreachable();
}
diff --git a/lib/riscv/sbi.c b/lib/riscv/sbi.c
index 2959378f..9dd11e9d 100644
--- a/lib/riscv/sbi.c
+++ b/lib/riscv/sbi.c
@@ -107,9 +107,9 @@ struct sbiret sbi_sse_inject(unsigned long event_id, unsigned long hart_id)
return sbi_ecall(SBI_EXT_SSE, SBI_EXT_SSE_INJECT, event_id, hart_id, 0, 0, 0, 0);
}
-void sbi_shutdown(void)
+void sbi_shutdown(unsigned int code)
{
- sbi_ecall(SBI_EXT_SRST, 0, 0, 0, 0, 0, 0, 0);
+ sbi_ecall(SBI_EXT_SRST, 0, 0, code, 0, 0, 0, 0);
puts("SBI shutdown failed!\n");
}
--
2.43.0
next reply other threads:[~2025-06-24 19:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 19:23 Jesse Taube [this message]
2025-06-25 8:33 ` [kvm-unit-tests PATCH v2] riscv: lib: sbi_shutdown add pass/fail exit code Andrew Jones
2025-06-25 14:31 ` Jesse Taube
2025-06-25 15:47 ` Andrew Jones
2025-07-02 14:45 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250624192317.278437-1-jesse@rivosinc.com \
--to=jesse@rivosinc.com \
--cc=andrew.jones@linux.dev \
--cc=cade.richard@gmail.com \
--cc=charlie@rivosinc.com \
--cc=cleger@rivosinc.com \
--cc=jamestiotio@gmail.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox