From: Jakub Kicinski <kuba@kernel.org>
To: Taehee Yoo <ap420073@gmail.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
andrew+netdev@lunn.ch, shuah@kernel.org, almasrymina@google.com,
sdf@fomichev.me, jdamato@fastly.com, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 net-next] selftests: devmem: configure HDS threshold
Date: Wed, 2 Jul 2025 11:39:30 -0700 [thread overview]
Message-ID: <20250702113930.79a9f060@kernel.org> (raw)
In-Reply-To: <20250702104249.1665034-1-ap420073@gmail.com>
On Wed, 2 Jul 2025 10:42:49 +0000 Taehee Yoo wrote:
> The devmem TCP requires the hds-thresh value to be 0, but it doesn't
> change it automatically.
> Therefore, make configure_headersplit() sets hds-thresh value to 0.
I don't see any undoing of the configuration :(
The selftest should leave the system in the state that it started.
We should either add some code to undo at shutdown or (preferably)
move the logic to the Python script where we can handle this more
cleanly with defer().
--
pw-bot: cr
next prev parent reply other threads:[~2025-07-02 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 10:42 [PATCH v2 net-next] selftests: devmem: configure HDS threshold Taehee Yoo
2025-07-02 15:37 ` Stanislav Fomichev
2025-07-02 16:12 ` Taehee Yoo
2025-07-03 15:41 ` Stanislav Fomichev
2025-07-02 18:39 ` Jakub Kicinski [this message]
2025-07-03 3:51 ` Taehee Yoo
2025-07-07 18:48 ` Mina Almasry
2025-07-07 20:10 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250702113930.79a9f060@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox