From: Jesse Taube <jesse@rivosinc.com>
To: kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
linux-kselftest@vger.kernel.org
Cc: "Clément Léger" <cleger@rivosinc.com>,
"Charlie Jenkins" <charlie@rivosinc.com>,
"Jesse Taube" <jesse@rivosinc.com>,
"Andrew Jones" <andrew.jones@linux.dev>,
"James Raphael Tiovalen" <jamestiotio@gmail.com>,
"Sean Christopherson" <seanjc@google.com>,
"Cade Richard" <cade.richard@gmail.com>
Subject: [kvm-unit-tests PATCH v3 2/2] riscv: lib: Add sbi-exit-code to configure and environment
Date: Wed, 9 Jul 2025 06:47:07 -0700 [thread overview]
Message-ID: <20250709134707.1931882-2-jesse@rivosinc.com> (raw)
In-Reply-To: <20250709134707.1931882-1-jesse@rivosinc.com>
Add --[enable|disable]-sbi-exit-code to configure script.
With the default value as disabled.
Add a check for SBI_EXIT_CODE in the environment, so that passing
of the test status is configurable from both the
environment and the configure script
Signed-off-by: Jesse Taube <jesse@rivosinc.com>
Reviewed-by: Andrew Jones <andrew.jones@linux.dev>
---
V1 -> V2:
- Factor out commonly used macros to new commit
- Use ternary operator over if
V2 -> V3:
- No changes
---
configure | 11 +++++++++++
lib/riscv/io.c | 4 +++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 20bf5042..7c949bdc 100755
--- a/configure
+++ b/configure
@@ -67,6 +67,7 @@ earlycon=
console=
efi=
efi_direct=
+sbi_exit_code=0
target_cpu=
# Enable -Werror by default for git repositories only (i.e. developer builds)
@@ -141,6 +142,9 @@ usage() {
system and run from the UEFI shell. Ignored when efi isn't enabled
and defaults to enabled when efi is enabled for riscv64.
(arm64 and riscv64 only)
+ --[enable|disable]-sbi-exit-code
+ Enable or disable sending pass/fail exit code to SBI SRST.
+ (disabled by default, riscv only)
EOF
exit 1
}
@@ -236,6 +240,12 @@ while [[ $optno -le $argc ]]; do
--disable-efi-direct)
efi_direct=n
;;
+ --enable-sbi-exit-code)
+ sbi_exit_code=1
+ ;;
+ --disable-sbi-exit-code)
+ sbi_exit_code=0
+ ;;
--enable-werror)
werror=-Werror
;;
@@ -551,6 +561,7 @@ EOF
elif [ "$arch" = "riscv32" ] || [ "$arch" = "riscv64" ]; then
echo "#define CONFIG_UART_EARLY_BASE ${uart_early_addr}" >> lib/config.h
[ "$console" = "sbi" ] && echo "#define CONFIG_SBI_CONSOLE" >> lib/config.h
+ echo "#define CONFIG_SBI_EXIT_CODE ${sbi_exit_code}" >> lib/config.h
echo >> lib/config.h
fi
echo "#endif" >> lib/config.h
diff --git a/lib/riscv/io.c b/lib/riscv/io.c
index b1163404..c46845de 100644
--- a/lib/riscv/io.c
+++ b/lib/riscv/io.c
@@ -6,6 +6,7 @@
* Copyright (C) 2023, Ventana Micro Systems Inc., Andrew Jones <ajones@ventanamicro.com>
*/
#include <libcflat.h>
+#include <argv.h>
#include <bitops.h>
#include <config.h>
#include <devicetree.h>
@@ -163,7 +164,8 @@ void halt(int code);
void exit(int code)
{
printf("\nEXIT: STATUS=%d\n", ((code) << 1) | 1);
- sbi_shutdown(code == 0);
+
+ sbi_shutdown(GET_CONFIG_OR_ENV(SBI_EXIT_CODE) ? code == 0 : true);
halt(code);
__builtin_unreachable();
}
--
2.43.0
next prev parent reply other threads:[~2025-07-09 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 13:47 [kvm-unit-tests PATCH v3 1/2] lib: Add STR_IS_Y and STR_IS_N for checking env vars Jesse Taube
2025-07-09 13:47 ` Jesse Taube [this message]
2025-07-09 16:58 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250709134707.1931882-2-jesse@rivosinc.com \
--to=jesse@rivosinc.com \
--cc=andrew.jones@linux.dev \
--cc=cade.richard@gmail.com \
--cc=charlie@rivosinc.com \
--cc=cleger@rivosinc.com \
--cc=jamestiotio@gmail.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox