From: Jakub Kicinski <kuba@kernel.org>
To: "Chia-Yu Chang (Nokia)" <chia-yu.chang@nokia-bell-labs.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
"alok.a.tiwari@oracle.com" <alok.a.tiwari@oracle.com>,
"pctammela@mojatatu.com" <pctammela@mojatatu.com>,
"horms@kernel.org" <horms@kernel.org>,
"donald.hunter@gmail.com" <donald.hunter@gmail.com>,
"xandfury@gmail.com" <xandfury@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"dave.taht@gmail.com" <dave.taht@gmail.com>,
"jhs@mojatatu.com" <jhs@mojatatu.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"ast@fiberby.net" <ast@fiberby.net>,
"liuhangbin@gmail.com" <liuhangbin@gmail.com>,
"shuah@kernel.org" <shuah@kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"ij@kernel.org" <ij@kernel.org>,
"ncardwell@google.com" <ncardwell@google.com>,
"Koen De Schepper (Nokia)" <koen.de_schepper@nokia-bell-labs.com>,
"g.white@cablelabs.com" <g.white@cablelabs.com>,
"ingemar.s.johansson@ericsson.com"
<ingemar.s.johansson@ericsson.com>,
"mirja.kuehlewind@ericsson.com" <mirja.kuehlewind@ericsson.com>,
"cheshire@apple.com" <cheshire@apple.com>,
"rs.ietf@gmx.at" <rs.ietf@gmx.at>,
"Jason_Livingood@comcast.com" <Jason_Livingood@comcast.com>,
"vidhi_goel@apple.com" <vidhi_goel@apple.com>
Subject: Re: [PATCH v21 net-next 1/6] sched: Struct definition and parsing of dualpi2 qdisc
Date: Wed, 9 Jul 2025 14:02:48 -0700 [thread overview]
Message-ID: <20250709140248.71603931@kernel.org> (raw)
In-Reply-To: <PAXPR07MB7984DEEC5D4DEF626359C2ECA349A@PAXPR07MB7984.eurprd07.prod.outlook.com>
On Wed, 9 Jul 2025 08:17:08 +0000 Chia-Yu Chang (Nokia) wrote:
> Thanks for clarification, then I will add one extra "int opt_flag = 0" and set the flag (e.g., opt_flag += 1 << TCA_DUALPI2_LIMIT).
>
> At the end will return an error message if no flag is set, like below example:
>
> if (!opt_flag) {
> sch_tree_unlock(sch);
> NL_SET_ERR_MSG_MOD(extack, "Dualpi2 options are empty");
> return -EINVAL;
> }
>
> Or is there any other suggested ways to do it, please let me know, thanks.
You don't have to track each option. I think it's enough to check if
the option nest is empty:
- if (!opt) {
+ if (!opt || !nla_len(opt)) {
next prev parent reply other threads:[~2025-07-09 21:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 3:28 [PATCH v21 net-next 0/6] DUALPI2 patch chia-yu.chang
2025-07-02 3:28 ` [PATCH v21 net-next 1/6] sched: Struct definition and parsing of dualpi2 qdisc chia-yu.chang
2025-07-08 10:29 ` Paolo Abeni
2025-07-08 20:22 ` Chia-Yu Chang (Nokia)
2025-07-09 0:30 ` Jakub Kicinski
2025-07-09 8:17 ` Chia-Yu Chang (Nokia)
2025-07-09 21:02 ` Jakub Kicinski [this message]
2025-07-02 3:28 ` [PATCH v21 net-next 2/6] sched: Dump configuration and statistics " chia-yu.chang
2025-07-02 3:28 ` [PATCH v21 net-next 3/6] sched: Add enqueue/dequeue " chia-yu.chang
2025-07-02 3:28 ` [PATCH v21 net-next 4/6] selftests/tc-testing: Fix warning and style check on tdc.sh chia-yu.chang
2025-07-02 3:28 ` [PATCH v21 net-next 5/6] selftests/tc-testing: Add selftests for qdisc DualPI2 chia-yu.chang
2025-07-02 3:28 ` [PATCH v21 net-next 6/6] Documentation: netlink: specs: tc: Add DualPI2 specification chia-yu.chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250709140248.71603931@kernel.org \
--to=kuba@kernel.org \
--cc=Jason_Livingood@comcast.com \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@fiberby.net \
--cc=cheshire@apple.com \
--cc=chia-yu.chang@nokia-bell-labs.com \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=g.white@cablelabs.com \
--cc=horms@kernel.org \
--cc=ij@kernel.org \
--cc=ingemar.s.johansson@ericsson.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=koen.de_schepper@nokia-bell-labs.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=mirja.kuehlewind@ericsson.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=rs.ietf@gmx.at \
--cc=shuah@kernel.org \
--cc=stephen@networkplumber.org \
--cc=vidhi_goel@apple.com \
--cc=xandfury@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).