From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Benjamin Berg <benjamin@sipsolutions.net>,
linux-kselftest@vger.kernel.org,
Benjamin Berg <benjamin.berg@intel.com>
Subject: Re: [PATCH 2/3] tools/nolibc: add more generic BITSET_* macros for FD_*
Date: Wed, 9 Jul 2025 20:44:43 +0200 [thread overview]
Message-ID: <20250709184443.GA15954@1wt.eu> (raw)
In-Reply-To: <1f927eac-15b4-41f2-843a-5226015da96b@t-8ch.de>
Hi Thomas,
On Wed, Jul 09, 2025 at 08:36:49PM +0200, Thomas Weißschuh wrote:
> > +#define FD_CLR(fd, set) BITSET_CLR(fd, (set)->fds)
> > +#define FD_SET(fd, set) BITSET_SET(fd, (set)->fds)
> > +#define FD_ISSET(fd, set) BITSET_ISSET(fd, (set)->fds)
> > +#define FD_ZERO(set) BITSET_ZERO((set)->fds)
>
> These could be inline function I think.
It's better not do, because man says they are macros, and I've seen
programs using ifdef on them (not to mean that it's common but it's
supposed to be possible according to the man).
Cheers,
Willy
next prev parent reply other threads:[~2025-07-09 18:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 15:55 [PATCH 0/3] signal handling support for nolibc Benjamin Berg
2025-07-09 15:55 ` [PATCH 1/3] tools/nolibc: show failed run if test process crashes Benjamin Berg
2025-07-09 16:27 ` Thomas Weißschuh
2025-07-09 15:55 ` [PATCH 2/3] tools/nolibc: add more generic BITSET_* macros for FD_* Benjamin Berg
2025-07-09 18:36 ` Thomas Weißschuh
2025-07-09 18:44 ` Willy Tarreau [this message]
2025-07-11 4:53 ` Thomas Weißschuh
2025-07-09 15:55 ` [PATCH 3/3] tools/nolibc: add signal support Benjamin Berg
2025-07-09 21:21 ` Thomas Weißschuh
2025-07-10 5:34 ` Benjamin Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250709184443.GA15954@1wt.eu \
--to=w@1wt.eu \
--cc=benjamin.berg@intel.com \
--cc=benjamin@sipsolutions.net \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).