From: Jakub Kicinski <kuba@kernel.org>
To: Mohsin Bashir <mohsin.bashr@gmail.com>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
shuah@kernel.org, horms@kernel.org, cratiu@nvidia.com,
noren@nvidia.com, cjubran@nvidia.com, mbloch@nvidia.com,
jdamato@fastly.com, gal@nvidia.com, sdf@fomichev.me,
ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 2/5] selftests: drv-net: Test XDP_PASS/DROP support
Date: Fri, 11 Jul 2025 06:41:46 -0700 [thread overview]
Message-ID: <20250711064146.0db275a7@kernel.org> (raw)
In-Reply-To: <20250710184351.63797-3-mohsin.bashr@gmail.com>
On Thu, 10 Jul 2025 11:43:48 -0700 Mohsin Bashir wrote:
> + try:
> + cmd(
> + f"ip link set dev {cfg.ifname} mtu {bpf_info.mtu} xdp obj {abs_path} "
> + f"sec {bpf_info.xdp_sec}",
> + shell=True
> + )
> + defer(ip, f"link set dev {cfg.ifname} mtu 1500 xdp off")
> + except Exception as e:
> + raise KsftSkipEx(f"Failed to attach XDP porgram: {bpf_info.name}") from e
Please don't catch the exception here, let it break the test.
The cmd exception carries the info we need to debug, I had
to remove this to see why the test was skipping. We could try
to add the error lines to the SkipEx but frankly I don't think
it's worth the LoC.
--
pw-bot: cr
next prev parent reply other threads:[~2025-07-11 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 18:43 [PATCH net-next V2 0/5] selftests: drv-net: Test XDP native support Mohsin Bashir
2025-07-10 18:43 ` [PATCH net-next 1/5] selftests: drv-net: Add bpftool util Mohsin Bashir
2025-07-11 17:10 ` Jakub Kicinski
2025-07-10 18:43 ` [PATCH net-next 2/5] selftests: drv-net: Test XDP_PASS/DROP support Mohsin Bashir
2025-07-11 13:41 ` Jakub Kicinski [this message]
2025-07-10 18:43 ` [PATCH net-next 3/5] selftests: drv-net: Test XDP_TX support Mohsin Bashir
2025-07-10 18:43 ` [PATCH net-next 4/5] selftests: drv-net: Test tail-adjustment support Mohsin Bashir
2025-07-10 18:43 ` [PATCH net-next 5/5] selftests: drv-net: Test head-adjustment support Mohsin Bashir
2025-07-11 13:39 ` [PATCH net-next V2 0/5] selftests: drv-net: Test XDP native support Jakub Kicinski
2025-07-11 17:29 ` Mohsin Bashir
2025-07-11 17:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250711064146.0db275a7@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cjubran@nvidia.com \
--cc=cratiu@nvidia.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).