From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
shuah@kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: rtnetlink: try double sleep to give WQ a chance
Date: Mon, 14 Jul 2025 15:30:54 -0700 [thread overview]
Message-ID: <20250714153054.07b2095e@kernel.org> (raw)
In-Reply-To: <aHSvbVcc0DKMGcYT@fedora>
On Mon, 14 Jul 2025 07:19:09 +0000 Hangbin Liu wrote:
> > > How about use slowwait to check if the address still exists.
> >
> > Weirdly if we read the addresses twice they disappear, I haven't looked
> > into the code for the why, but seemed like using slowwait could
> > potentially mask the addresses sticking around when nobody runs
> > the Netlink handlers for a while? Dunno..
>
> Not sure if I understand correctly. Do you mean the addresses will keep there
> if we use slowwait?
No, I mean there may be false negatives, not false positive.
But maybe it's fine, it will definitely prevent flakes.
Could you post the slowwait patch officially?
--
pw-bot: cr
prev parent reply other threads:[~2025-07-14 22:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 14:53 [PATCH net] selftests: rtnetlink: try double sleep to give WQ a chance Jakub Kicinski
2025-07-11 2:14 ` Hangbin Liu
2025-07-11 14:17 ` Jakub Kicinski
2025-07-14 7:19 ` Hangbin Liu
2025-07-14 22:30 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250714153054.07b2095e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).