From: Jakub Kicinski <kuba@kernel.org>
To: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Cc: mptcp@lists.linux.dev, Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>,
Christoph Paasch <cpaasch@openai.com>,
Davide Caratti <dcaratti@redhat.com>,
Florian Westphal <fw@strlen.de>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v2 0/2] selftests: mptcp: connect: cover alt modes
Date: Tue, 15 Jul 2025 18:53:08 -0700 [thread overview]
Message-ID: <20250715185308.2ad30691@kernel.org> (raw)
In-Reply-To: <20250715-net-mptcp-sft-connect-alt-v2-0-8230ddd82454@kernel.org>
On Tue, 15 Jul 2025 20:43:27 +0200 Matthieu Baerts (NGI0) wrote:
> mptcp_connect.sh can be executed manually with "-m <MODE>" and "-C" to
> make sure everything works as expected when using "mmap" and "sendfile"
> modes instead of "poll", and with the MPTCP checksum support.
>
> These modes should be validated, but they are not when the selftests are
> executed via the kselftest helpers. It means that most CIs validating
> these selftests, like NIPA for the net development trees and LKFT for
> the stable ones, are not covering these modes.
>
> To fix that, new test programs have been added, simply calling
> mptcp_connect.sh with the right parameters.
>
> The first patch can be backported up to v5.6, and the second one up to
> v5.14.
Looks like the failures that Paolo flagged yesterday:
https://lore.kernel.org/all/a7a89aa2-7354-42c7-8219-99a3cafd3b33@redhat.com/
are back as soon as this hit NIPA :(
https://netdev.bots.linux.dev/contest.html?branch=net-next-2025-07-16--00-00&executor=vmksft-mptcp&pw-n=0&pass=0
No idea why TBH, the tests run sequentially and connect.sh run before
any of the new ones.
I'm gonna leave it in patchwork in case the next run is clean,
please use pw-bot to discard them if they keep failing.
next prev parent reply other threads:[~2025-07-16 1:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 18:43 [PATCH net v2 0/2] selftests: mptcp: connect: cover alt modes Matthieu Baerts (NGI0)
2025-07-15 18:43 ` [PATCH net v2 1/2] selftests: mptcp: connect: also " Matthieu Baerts (NGI0)
2025-07-15 18:43 ` [PATCH net v2 2/2] selftests: mptcp: connect: also cover checksum Matthieu Baerts (NGI0)
2025-07-16 1:53 ` Jakub Kicinski [this message]
2025-07-16 14:26 ` [PATCH net v2 0/2] selftests: mptcp: connect: cover alt modes Jakub Kicinski
2025-07-16 14:55 ` Matthieu Baerts
2025-07-16 15:36 ` Jakub Kicinski
2025-07-16 16:35 ` Matthieu Baerts
2025-07-17 14:42 ` Jakub Kicinski
2025-07-17 23:49 ` Matthieu Baerts
2025-07-18 1:33 ` Jakub Kicinski
2025-07-19 1:35 ` Jakub Kicinski
2025-07-21 23:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250715185308.2ad30691@kernel.org \
--to=kuba@kernel.org \
--cc=cpaasch@openai.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).