From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>, Shuah Khan <shuah@kernel.org>,
damon@lists.linux.dev, kernel-team@meta.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH 00/22] selftests/damon/sysfs.py: test all parameters
Date: Sun, 20 Jul 2025 10:16:30 -0700 [thread overview]
Message-ID: <20250720171652.92309-1-sj@kernel.org> (raw)
sysfs.py tests if DAMON sysfs interface is passing the user-requested
parameters to DAMON as expected. But only the default (minimum)
parameters are being tested. This is partially because _damon_sysfs.py,
which is the library for making the parameter requests, is not
supporting the entire parameters. The internal DAMON status dump script
(drgn_dump_damon_status.py) is also not dumping entire parameters.
Extend the test coverage by updating parameters input and status dumping
scripts to support all parameters, and writing additional tests using
those.
This increased test coverage actually found one real bug
(https://lore.kernel.org/20250719181932.72944-1-sj@kernel.org).
First seven patches (1-7) extend _damon_sysfs.py for all parameters
setup. The eight patch (8) fixes _damon_sysfs.py to use correct max
nr_acceses and age values for their type. Following three patches
(9-11) extend drgn_dump_damon_status.py to dump full DAMON parameters.
Following nine patches (12-20) refactor sysfs.py for general testing
code reuse, and extend it for full parameters check. Finally, two
patches (21 and 22) add test cases in sysfs.py for full parameters
testing.
SeongJae Park (22):
selftests/damon/_damon_sysfs: support DAMOS watermarks setup
selftests/damon/_damon_sysfs: support DAMOS filters setup
selftests/damon/_damon_sysfs: support monitoring intervals goal setup
selftests/damon/_damon_sysfs: support DAMOS quota weights setup
selftests/damon/_damon_sysfs: support DAMOS quota goal nid setup
selftests/damon/_damon_sysfs: support DAMOS action dests setup
selftests/damon/_damon_sysfs: support DAMOS target_nid setup
selftests/damon/_damon_sysfs: use 2**32 - 1 as max nr_accesses and age
selftests/damon/drgn_dump_damon_status: dump damos->migrate_dests
selftests/damon/drgn_dump_damon_status: dump ctx->ops.id
selftests/damon/drgn_dump_damon_status: dump DAMOS filters
selftests/damon/sysfs.py: generalize DAMOS Watermarks commit assertion
selftests/damon/sysfs.py: generalize DamosQuota commit assertion
selftests/damon/sysfs.py: test quota goal commitment
selftests/damon/sysfs.py: test DAMOS destinations commitment
selftests/damon/sysfs.py: generalize DAMOS schemes commit assertion
selftests/damon/sysfs.py: test DAMOS filters commitment
selftests/damon/sysfs.py: generalize DAMOS schemes commit assertion
selftests/damon/sysfs.py: generalize monitoring attributes commit
assertion
selftests/damon/sysfs.py: generalize DAMON context commit assertion
selftests/damon/sysfs.py: test non-default parameters runtime commit
selftests/damon/sysfs.py: test runtime reduction of DAMON parameters
tools/testing/selftests/damon/_damon_sysfs.py | 301 +++++++++++++++++-
.../selftests/damon/drgn_dump_damon_status.py | 63 +++-
tools/testing/selftests/damon/sysfs.py | 284 +++++++++++++----
3 files changed, 568 insertions(+), 80 deletions(-)
base-commit: fc8066077f44a4fd43f8fdb12bc238f8fbeaa3c5
--
2.39.5
next reply other threads:[~2025-07-20 17:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-20 17:16 SeongJae Park [this message]
2025-07-20 17:16 ` [PATCH 01/22] selftests/damon/_damon_sysfs: support DAMOS watermarks setup SeongJae Park
2025-07-20 17:16 ` [PATCH 02/22] selftests/damon/_damon_sysfs: support DAMOS filters setup SeongJae Park
2025-07-20 17:16 ` [PATCH 03/22] selftests/damon/_damon_sysfs: support monitoring intervals goal setup SeongJae Park
2025-07-20 17:16 ` [PATCH 04/22] selftests/damon/_damon_sysfs: support DAMOS quota weights setup SeongJae Park
2025-07-20 17:16 ` [PATCH 05/22] selftests/damon/_damon_sysfs: support DAMOS quota goal nid setup SeongJae Park
2025-07-20 17:16 ` [PATCH 06/22] selftests/damon/_damon_sysfs: support DAMOS action dests setup SeongJae Park
2025-07-20 17:16 ` [PATCH 07/22] selftests/damon/_damon_sysfs: support DAMOS target_nid setup SeongJae Park
2025-07-20 17:16 ` [PATCH 08/22] selftests/damon/_damon_sysfs: use 2**32 - 1 as max nr_accesses and age SeongJae Park
2025-07-20 17:16 ` [PATCH 09/22] selftests/damon/drgn_dump_damon_status: dump damos->migrate_dests SeongJae Park
2025-07-20 17:16 ` [PATCH 10/22] selftests/damon/drgn_dump_damon_status: dump ctx->ops.id SeongJae Park
2025-07-20 17:16 ` [PATCH 11/22] selftests/damon/drgn_dump_damon_status: dump DAMOS filters SeongJae Park
2025-07-20 17:16 ` [PATCH 12/22] selftests/damon/sysfs.py: generalize DAMOS Watermarks commit assertion SeongJae Park
2025-07-20 17:16 ` [PATCH 13/22] selftests/damon/sysfs.py: generalize DamosQuota " SeongJae Park
2025-07-20 17:16 ` [PATCH 14/22] selftests/damon/sysfs.py: test quota goal commitment SeongJae Park
2025-07-20 17:16 ` [PATCH 15/22] selftests/damon/sysfs.py: test DAMOS destinations commitment SeongJae Park
2025-07-20 17:16 ` [PATCH 16/22] selftests/damon/sysfs.py: generalize DAMOS schemes commit assertion SeongJae Park
2025-07-22 3:09 ` Andrew Morton
2025-07-22 4:04 ` SeongJae Park
2025-07-20 17:16 ` [PATCH 17/22] selftests/damon/sysfs.py: test DAMOS filters commitment SeongJae Park
2025-07-20 17:16 ` [PATCH 18/22] selftests/damon/sysfs.py: generalize DAMOS schemes commit assertion SeongJae Park
2025-07-20 17:16 ` [PATCH 19/22] selftests/damon/sysfs.py: generalize monitoring attributes " SeongJae Park
2025-07-20 17:16 ` [PATCH 20/22] selftests/damon/sysfs.py: generalize DAMON context " SeongJae Park
2025-07-20 17:16 ` [PATCH 21/22] selftests/damon/sysfs.py: test non-default parameters runtime commit SeongJae Park
2025-07-20 17:16 ` [PATCH 22/22] selftests/damon/sysfs.py: test runtime reduction of DAMON parameters SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250720171652.92309-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).