linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>, Shuah Khan <shuah@kernel.org>,
	damon@lists.linux.dev, kernel-team@meta.com,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-mm@kvack.org
Subject: [PATCH 17/22] selftests/damon/sysfs.py: test DAMOS filters commitment
Date: Sun, 20 Jul 2025 10:16:47 -0700	[thread overview]
Message-ID: <20250720171652.92309-18-sj@kernel.org> (raw)
In-Reply-To: <20250720171652.92309-1-sj@kernel.org>

Current DAMOS scheme commitment assertion is not testing DAMOS filters.
Add the test.

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 tools/testing/selftests/damon/sysfs.py | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/tools/testing/selftests/damon/sysfs.py b/tools/testing/selftests/damon/sysfs.py
index 584a71cbb891..a32871b9b0f2 100755
--- a/tools/testing/selftests/damon/sysfs.py
+++ b/tools/testing/selftests/damon/sysfs.py
@@ -76,6 +76,21 @@ def assert_migrate_dests_committed(dests, dump):
         assert_true(dump['node_id_arr'][idx] == dest.id, 'node_id', dump)
         assert_true(dump['weight_arr'][idx] == dest.weight, 'weight', dump)
 
+def assert_filter_committed(filter_, dump):
+    assert_true(filter_.type_ == dump['type'], 'type', dump)
+    assert_true(filter_.matching == dump['matching'], 'matching', dump)
+    assert_true(filter_.allow == dump['allow'], 'allow', dump)
+    # TODO: check memcg_path and memcg_id if type is memcg
+    if filter_.type_ == 'addr':
+        assert_true([filter_.addr_start, filter_.addr_end] ==
+                    dump['addr_range'], 'addr_range', dump)
+    elif filter_.type_ == 'target':
+        assert_true(filter_.target_idx == dump['target_idx'], 'target_idx',
+                    dump)
+    elif filter_.type_ == 'hugepage_size':
+        assert_true([filter_.min_, filter_.max_] == dump['sz_range'],
+                    'sz_range', dump)
+
 def assert_access_pattern_committed(pattern, dump):
     assert_true(dump['min_sz_region'] == pattern.size[0], 'min_sz_region',
                 dump)
@@ -111,6 +126,11 @@ def assert_scheme_committed(scheme, dump):
     assert_migrate_dests_committed(scheme.dests, dump['migrate_dests'])
     assert_quota_committed(scheme.quota, dump['quota'])
     assert_watermarks_committed(scheme.watermarks, dump['wmarks'])
+    # TODO: test filters directory
+    for idx, f in enumerate(scheme.core_filters.filters):
+        assert_filter_committed(f, dump['filters'][idx])
+    for idx, f in enumerate(scheme.ops_filters.filters):
+        assert_filter_committed(f, dump['ops_filters'][idx])
 
 def main():
     kdamonds = _damon_sysfs.Kdamonds(
-- 
2.39.5

  parent reply	other threads:[~2025-07-20 17:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-20 17:16 [PATCH 00/22] selftests/damon/sysfs.py: test all parameters SeongJae Park
2025-07-20 17:16 ` [PATCH 01/22] selftests/damon/_damon_sysfs: support DAMOS watermarks setup SeongJae Park
2025-07-20 17:16 ` [PATCH 02/22] selftests/damon/_damon_sysfs: support DAMOS filters setup SeongJae Park
2025-07-20 17:16 ` [PATCH 03/22] selftests/damon/_damon_sysfs: support monitoring intervals goal setup SeongJae Park
2025-07-20 17:16 ` [PATCH 04/22] selftests/damon/_damon_sysfs: support DAMOS quota weights setup SeongJae Park
2025-07-20 17:16 ` [PATCH 05/22] selftests/damon/_damon_sysfs: support DAMOS quota goal nid setup SeongJae Park
2025-07-20 17:16 ` [PATCH 06/22] selftests/damon/_damon_sysfs: support DAMOS action dests setup SeongJae Park
2025-07-20 17:16 ` [PATCH 07/22] selftests/damon/_damon_sysfs: support DAMOS target_nid setup SeongJae Park
2025-07-20 17:16 ` [PATCH 08/22] selftests/damon/_damon_sysfs: use 2**32 - 1 as max nr_accesses and age SeongJae Park
2025-07-20 17:16 ` [PATCH 09/22] selftests/damon/drgn_dump_damon_status: dump damos->migrate_dests SeongJae Park
2025-07-20 17:16 ` [PATCH 10/22] selftests/damon/drgn_dump_damon_status: dump ctx->ops.id SeongJae Park
2025-07-20 17:16 ` [PATCH 11/22] selftests/damon/drgn_dump_damon_status: dump DAMOS filters SeongJae Park
2025-07-20 17:16 ` [PATCH 12/22] selftests/damon/sysfs.py: generalize DAMOS Watermarks commit assertion SeongJae Park
2025-07-20 17:16 ` [PATCH 13/22] selftests/damon/sysfs.py: generalize DamosQuota " SeongJae Park
2025-07-20 17:16 ` [PATCH 14/22] selftests/damon/sysfs.py: test quota goal commitment SeongJae Park
2025-07-20 17:16 ` [PATCH 15/22] selftests/damon/sysfs.py: test DAMOS destinations commitment SeongJae Park
2025-07-20 17:16 ` [PATCH 16/22] selftests/damon/sysfs.py: generalize DAMOS schemes commit assertion SeongJae Park
2025-07-22  3:09   ` Andrew Morton
2025-07-22  4:04     ` SeongJae Park
2025-07-20 17:16 ` SeongJae Park [this message]
2025-07-20 17:16 ` [PATCH 18/22] " SeongJae Park
2025-07-20 17:16 ` [PATCH 19/22] selftests/damon/sysfs.py: generalize monitoring attributes " SeongJae Park
2025-07-20 17:16 ` [PATCH 20/22] selftests/damon/sysfs.py: generalize DAMON context " SeongJae Park
2025-07-20 17:16 ` [PATCH 21/22] selftests/damon/sysfs.py: test non-default parameters runtime commit SeongJae Park
2025-07-20 17:16 ` [PATCH 22/22] selftests/damon/sysfs.py: test runtime reduction of DAMON parameters SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250720171652.92309-18-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).