From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>, Shuah Khan <shuah@kernel.org>,
damon@lists.linux.dev, kernel-team@meta.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH 03/22] selftests/damon/_damon_sysfs: support monitoring intervals goal setup
Date: Sun, 20 Jul 2025 10:16:33 -0700 [thread overview]
Message-ID: <20250720171652.92309-4-sj@kernel.org> (raw)
In-Reply-To: <20250720171652.92309-1-sj@kernel.org>
_damon_sysfs.py contains code for test-purpose DAMON sysfs interface
control. Add support of the monitoring intervals auto-tune goal setup
for more tests.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
tools/testing/selftests/damon/_damon_sysfs.py | 43 ++++++++++++++++++-
1 file changed, 42 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/damon/_damon_sysfs.py b/tools/testing/selftests/damon/_damon_sysfs.py
index f853af6ad926..ec6230929d36 100644
--- a/tools/testing/selftests/damon/_damon_sysfs.py
+++ b/tools/testing/selftests/damon/_damon_sysfs.py
@@ -405,18 +405,56 @@ class DamonTarget:
return write_file(
os.path.join(self.sysfs_dir(), 'pid_target'), self.pid)
+class IntervalsGoal:
+ access_bp = None
+ aggrs = None
+ min_sample_us = None
+ max_sample_us = None
+ attrs = None # owner DamonAttrs
+
+ def __init__(self, access_bp=0, aggrs=0, min_sample_us=0, max_sample_us=0):
+ self.access_bp = access_bp
+ self.aggrs = aggrs
+ self.min_sample_us = min_sample_us
+ self.max_sample_us = max_sample_us
+
+ def sysfs_dir(self):
+ return os.path.join(self.attrs.interval_sysfs_dir(), 'intervals_goal')
+
+ def stage(self):
+ err = write_file(
+ os.path.join(self.sysfs_dir(), 'access_bp'), self.access_bp)
+ if err is not None:
+ return err
+ err = write_file(os.path.join(self.sysfs_dir(), 'aggrs'), self.aggrs)
+ if err is not None:
+ return err
+ err = write_file(os.path.join(self.sysfs_dir(), 'min_sample_us'),
+ self.min_sample_us)
+ if err is not None:
+ return err
+ err = write_file(os.path.join(self.sysfs_dir(), 'max_sample_us'),
+ self.max_sample_us)
+ if err is not None:
+ return err
+ return None
+
class DamonAttrs:
sample_us = None
aggr_us = None
+ intervals_goal = None
update_us = None
min_nr_regions = None
max_nr_regions = None
context = None
- def __init__(self, sample_us=5000, aggr_us=100000, update_us=1000000,
+ def __init__(self, sample_us=5000, aggr_us=100000,
+ intervals_goal=IntervalsGoal(), update_us=1000000,
min_nr_regions=10, max_nr_regions=1000):
self.sample_us = sample_us
self.aggr_us = aggr_us
+ self.intervals_goal = intervals_goal
+ self.intervals_goal.attrs = self
self.update_us = update_us
self.min_nr_regions = min_nr_regions
self.max_nr_regions = max_nr_regions
@@ -436,6 +474,9 @@ class DamonAttrs:
return err
err = write_file(os.path.join(self.interval_sysfs_dir(), 'aggr_us'),
self.aggr_us)
+ if err is not None:
+ return err
+ err = self.intervals_goal.stage()
if err is not None:
return err
err = write_file(os.path.join(self.interval_sysfs_dir(), 'update_us'),
--
2.39.5
next prev parent reply other threads:[~2025-07-20 17:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-20 17:16 [PATCH 00/22] selftests/damon/sysfs.py: test all parameters SeongJae Park
2025-07-20 17:16 ` [PATCH 01/22] selftests/damon/_damon_sysfs: support DAMOS watermarks setup SeongJae Park
2025-07-20 17:16 ` [PATCH 02/22] selftests/damon/_damon_sysfs: support DAMOS filters setup SeongJae Park
2025-07-20 17:16 ` SeongJae Park [this message]
2025-07-20 17:16 ` [PATCH 04/22] selftests/damon/_damon_sysfs: support DAMOS quota weights setup SeongJae Park
2025-07-20 17:16 ` [PATCH 05/22] selftests/damon/_damon_sysfs: support DAMOS quota goal nid setup SeongJae Park
2025-07-20 17:16 ` [PATCH 06/22] selftests/damon/_damon_sysfs: support DAMOS action dests setup SeongJae Park
2025-07-20 17:16 ` [PATCH 07/22] selftests/damon/_damon_sysfs: support DAMOS target_nid setup SeongJae Park
2025-07-20 17:16 ` [PATCH 08/22] selftests/damon/_damon_sysfs: use 2**32 - 1 as max nr_accesses and age SeongJae Park
2025-07-20 17:16 ` [PATCH 09/22] selftests/damon/drgn_dump_damon_status: dump damos->migrate_dests SeongJae Park
2025-07-20 17:16 ` [PATCH 10/22] selftests/damon/drgn_dump_damon_status: dump ctx->ops.id SeongJae Park
2025-07-20 17:16 ` [PATCH 11/22] selftests/damon/drgn_dump_damon_status: dump DAMOS filters SeongJae Park
2025-07-20 17:16 ` [PATCH 12/22] selftests/damon/sysfs.py: generalize DAMOS Watermarks commit assertion SeongJae Park
2025-07-20 17:16 ` [PATCH 13/22] selftests/damon/sysfs.py: generalize DamosQuota " SeongJae Park
2025-07-20 17:16 ` [PATCH 14/22] selftests/damon/sysfs.py: test quota goal commitment SeongJae Park
2025-07-20 17:16 ` [PATCH 15/22] selftests/damon/sysfs.py: test DAMOS destinations commitment SeongJae Park
2025-07-20 17:16 ` [PATCH 16/22] selftests/damon/sysfs.py: generalize DAMOS schemes commit assertion SeongJae Park
2025-07-22 3:09 ` Andrew Morton
2025-07-22 4:04 ` SeongJae Park
2025-07-20 17:16 ` [PATCH 17/22] selftests/damon/sysfs.py: test DAMOS filters commitment SeongJae Park
2025-07-20 17:16 ` [PATCH 18/22] selftests/damon/sysfs.py: generalize DAMOS schemes commit assertion SeongJae Park
2025-07-20 17:16 ` [PATCH 19/22] selftests/damon/sysfs.py: generalize monitoring attributes " SeongJae Park
2025-07-20 17:16 ` [PATCH 20/22] selftests/damon/sysfs.py: generalize DAMON context " SeongJae Park
2025-07-20 17:16 ` [PATCH 21/22] selftests/damon/sysfs.py: test non-default parameters runtime commit SeongJae Park
2025-07-20 17:16 ` [PATCH 22/22] selftests/damon/sysfs.py: test runtime reduction of DAMON parameters SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250720171652.92309-4-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).