linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aboorva Devarajan <aboorvad@linux.ibm.com>
To: akpm@linux-foundation.org, Liam.Howlett@oracle.com,
	lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de,
	david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com,
	npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
	baohua@kernel.org
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, donettom@linux.ibm.com,
	ritesh.list@gmail.com, aboorvad@linux.ibm.com
Subject: [PATCH v3 1/7] mm/selftests: Fix incorrect pointer being passed to mark_range()
Date: Tue, 29 Jul 2025 11:03:57 +0530	[thread overview]
Message-ID: <20250729053403.1071807-2-aboorvad@linux.ibm.com> (raw)
In-Reply-To: <20250729053403.1071807-1-aboorvad@linux.ibm.com>

From: Donet Tom <donettom@linux.ibm.com>

In main(), the high address is stored in hptr, but for mark_range(),
the address passed is ptr, not hptr. Fixed this by changing ptr[i] to
hptr[i] in mark_range() function call.

Fixes: b2a79f62133a ("selftests/mm: virtual_address_range: unmap chunks after validation")
Reviewed-by: Dev Jain <dev.jain@arm.com>
Acked-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Zi Yan <ziy@nvidia.com>
Co-developed-by: Aboorva Devarajan <aboorvad@linux.ibm.com>
Signed-off-by: Aboorva Devarajan <aboorvad@linux.ibm.com>
Signed-off-by: Donet Tom <donettom@linux.ibm.com>
---
 tools/testing/selftests/mm/virtual_address_range.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/testing/selftests/mm/virtual_address_range.c
index 169dbd692bf5..e24c36a39f22 100644
--- a/tools/testing/selftests/mm/virtual_address_range.c
+++ b/tools/testing/selftests/mm/virtual_address_range.c
@@ -227,7 +227,7 @@ int main(int argc, char *argv[])
 		if (hptr[i] == MAP_FAILED)
 			break;
 
-		mark_range(ptr[i], MAP_CHUNK_SIZE);
+		mark_range(hptr[i], MAP_CHUNK_SIZE);
 		validate_addr(hptr[i], 1);
 	}
 	hchunks = i;
-- 
2.47.1


  reply	other threads:[~2025-07-29  5:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29  5:33 [PATCH v3 0/7] selftests/mm: Fix false positives and skip unsupported tests Aboorva Devarajan
2025-07-29  5:33 ` Aboorva Devarajan [this message]
2025-07-29  5:33 ` [PATCH v3 2/7] selftests/mm: Add support to test 4PB VA on PPC64 Aboorva Devarajan
2025-07-29  5:33 ` [PATCH v3 3/7] selftest/mm: Fix ksm_funtional_test failures Aboorva Devarajan
2025-08-04  9:11   ` Wei Yang
2025-08-04 14:36     ` David Hildenbrand
2025-08-05  6:09     ` Donet Tom
2025-08-05 17:03       ` Wei Yang
2025-08-06 13:00         ` Donet Tom
2025-08-06 14:54           ` Wei Yang
2025-08-07  9:26             ` Donet Tom
2025-08-08  2:58               ` Wei Yang
2025-08-08 14:25                 ` Donet Tom
2025-08-09 18:32                   ` Wei Yang
2025-07-29  5:34 ` [PATCH v3 4/7] mm/selftests: Fix split_huge_page_test failure on systems with 64KB page size Aboorva Devarajan
2025-08-04  9:04   ` Wei Yang
2025-08-04 14:33     ` David Hildenbrand
2025-08-05  6:13     ` Donet Tom
2025-07-29  5:34 ` [PATCH v3 5/7] selftests/mm: Fix child process exit codes in ksm_functional_tests Aboorva Devarajan
2025-07-29  5:34 ` [PATCH v3 6/7] selftests/mm: Skip thuge-gen test if system is not setup properly Aboorva Devarajan
2025-07-29  5:34 ` [PATCH v3 7/7] selftests/mm: Skip hugepage-mremap test if userfaultfd unavailable Aboorva Devarajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250729053403.1071807-2-aboorvad@linux.ibm.com \
    --to=aboorvad@linux.ibm.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@redhat.com \
    --cc=dev.jain@arm.com \
    --cc=donettom@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=npache@redhat.com \
    --cc=pfalcato@suse.de \
    --cc=ritesh.list@gmail.com \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).