linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Berg <benjamin@sipsolutions.net>
To: "Willy Tarreau" <w@1wt.eu>,
	"Thomas Weißschuh" <linux@weissschuh.net>,
	linux-kselftest@vger.kernel.org
Cc: Benjamin Berg <benjamin.berg@intel.com>
Subject: [PATCH v3 2/4] selftests/nolibc: remove outdated comment about construct order
Date: Thu, 31 Jul 2025 22:12:23 +0200	[thread overview]
Message-ID: <20250731201225.323254-3-benjamin@sipsolutions.net> (raw)
In-Reply-To: <20250731201225.323254-1-benjamin@sipsolutions.net>

From: Benjamin Berg <benjamin.berg@intel.com>

The constructor order is not (and should not) be tested. Remove the
comment.

Fixes: a782d45c867c ("selftests/nolibc: stop testing constructor order")
Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
---
 tools/testing/selftests/nolibc/nolibc-test.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
index 97efc98b6a3d..180f0436127a 100644
--- a/tools/testing/selftests/nolibc/nolibc-test.c
+++ b/tools/testing/selftests/nolibc/nolibc-test.c
@@ -686,7 +686,6 @@ int expect_strtox(int llen, void *func, const char *input, int base, intmax_t ex
 #define CASE_TEST(name) \
 	case __LINE__: llen += printf("%d %s", test, #name);
 
-/* constructors validate that they are executed in definition order */
 __attribute__((constructor))
 static void constructor1(void)
 {
-- 
2.50.1


  parent reply	other threads:[~2025-07-31 20:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-31 20:12 [PATCH v3 0/4] signal handling support for nolibc Benjamin Berg
2025-07-31 20:12 ` [PATCH v3 1/4] selftests/nolibc: fix EXPECT_NZ macro Benjamin Berg
2025-07-31 20:12 ` Benjamin Berg [this message]
2025-07-31 20:12 ` [PATCH v3 3/4] tools/nolibc: add more generic bitmask macros for FD_* Benjamin Berg
2025-07-31 20:12 ` [PATCH v3 4/4] tools/nolibc: add signal support Benjamin Berg
2025-08-01 15:09   ` Thomas Weißschuh
2025-08-02 10:26     ` Berg, Benjamin
2025-08-02 11:26       ` Thomas Weißschuh
2025-08-02 12:43         ` Berg, Benjamin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250731201225.323254-3-benjamin@sipsolutions.net \
    --to=benjamin@sipsolutions.net \
    --cc=benjamin.berg@intel.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).